feat(progess): emit progress-update #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroppy
commented
Apr 3, 2020
| @@ -31,11 +31,13 @@ module.exports = class WebsocketServer extends BaseServer { | |||
| const noop = () => {}; | |||
|
|
|||
| setInterval(() => { | |||
| this.wsServer.clients.forEach((ws) => { | |||
| if (ws.isAlive === false) return ws.terminate(); | |||
| this.wsServer.clients.forEach((socket) => { | |||
Codecov Report
@@ Coverage Diff @@
## master #2498 +/- ##
==========================================
+ Coverage 93.57% 93.58% +0.01%
==========================================
Files 34 34
Lines 1322 1325 +3
Branches 380 381 +1
==========================================
+ Hits 1237 1240 +3
Misses 83 83
Partials 2 2
Continue to review full report at Codecov.
|
|
|
||
| if (this.listeningApp) { | ||
| this.listeningApp.emit('progress-update', { percent, msg }); | ||
| } |
There was a problem hiding this comment.
Why we need check this.listeningApp? Is can be undefined?
There was a problem hiding this comment.
We need this condition because this.setupProgressPlugin is called before this.createServer.
｡◕ˇ_ˇ◕｡ ~/p/w/webpack-dev-server (feature/emit-progress-update| 🎃 1 📦 1) ᐅ npm run test:only -- progress-option
> [email protected] test:only /Users/hiroppy/programming/webpack/webpack-dev-server
> jest --forceExit "progress-option"
Test Suites: 1 failed, 1 total
Tests: 1 failed, 1 total
Snapshots: 0 total
Time: 3.755s
Ran all test suites matching /progress-option/i.
Force exiting Jest: Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test:only: `jest --forceExit "progress-option"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] test:only script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/hiroppy/.npm/_logs/2020-04-03T10_59_27_800Z-debug.log
> npm run test:only -- progress-option
> [email protected] test:only /Users/hiroppy/programming/webpack/webpack-dev-server
> jest --forceExit "progress-option"
console.info node_modules/webpack-log/src/loglevel/PrefixFactory.
js:55
ℹ ｢wds｣: Project is running at http://localhost:8134/
console.info node_modules/webpack-log/src/loglevel/PrefixFactory.js:55
ℹ ｢wds｣: webpack output is served from undefined
console.info node_modules/webpack-log/src/loglevel/PrefixFactory.js:55
ℹ ｢wds｣: Content not from webpack is served from /Users/hiroppy/programming/webpack/webpack-dev-server
PASS test/server/progress-option.test.js
progress
output
✓ should show percentage progress without profile data (570ms
)
Test Suites: 1 passed, 1 total
Tests: 1 passed, 1 total
Snapshots: 0 total
Time: 2.107s
Ran all test suites matching /progress-option/i.
Force exiting Jest: Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?
This log shows 2 situations that are added if or not.
alexander-akait
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1666
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
Emit
progress-updateevent.Breaking Changes
no
Additional Info