Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a prefix to the path that sockjs-node is mounted to #909

Closed
kellyrmilligan opened this issue May 17, 2017 · 3 comments
Closed

add a prefix to the path that sockjs-node is mounted to #909

kellyrmilligan opened this issue May 17, 2017 · 3 comments

Comments

@kellyrmilligan
Copy link
Contributor

Do you want to request a feature or report a bug?

What is the current behavior?

Currently, the path is always /sockjs-node.

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?

If this is a feature request, what is motivation or use case for changing the behavior?
The request would be to be able to be able to add a prefix to this path, in order to be able to have multiple apps running with webpack dev server in a reverse proxy scenario, in order to fully isolate an app running under a sub path.

see:
facebook/create-react-app#1887
and
facebook/create-react-app#1582

Proposal would be to add a configuration option to mount the sockjs handler to the express instance at a prefixed-path. this implies that the provided webpack dev client would also be able to access this same path so that they are in sync.

thoughts?
Please mention your webpack and Operating System version.

@kellyrmilligan
Copy link
Contributor Author

update, how about prefixing it with options.publicPath ?

@kellyrmilligan
Copy link
Contributor Author

is there any way to access the webpack config from within the client/index.js file? any variables injected when webpack is compiling it?

@shellscape
Copy link
Contributor

Closing this as the resolution to #1021 will resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants