Fix SPDY fails in node >= 11.1.0

[yi-ge]

In node v11+:

util.js:305
    throw new ERR_INVALID_ARG_TYPE('superCtor.prototype',
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "superCtor.prototype" property must be of type Object. Received type undefined

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

[yi-ge]

About it: https://github.com/spdy-http2/node-spdy/issues/350

[alexander-akait]

We need add tests

[codecov]

Codecov Report

Merging #1660 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
- Coverage   75.12%   75.08%   -0.05%     
==========================================
  Files          18       18              
  Lines         591      590       -1     
  Branches      171      171              
==========================================
- Hits          444      443       -1     
  Misses        113      113              
  Partials       34       34

Impacted Files	Coverage Δ
lib/Server.js	78.43% <100%> (-0.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78a9a3...6a655ec. Read the comment docs.

[alexander-akait]

Also please accept CLA

[yi-ge]

t.js:

const spdy = require('spdy');

You can run it (node t.js) in node v11.9.0.

About: spdy-http2/node-spdy#350

[yi-ge]

😄

[alexander-akait]

@yi-ge looks you catch the bug in nodejs 😄 Can you create issue in nodejs and add comment with link in source code

[yi-ge]

@evilebottnawi Thank you.

[alexander-akait]

Strange can't reproducible locally on latest nodejs

[yi-ge]

@evilebottnawi sdpy v4.0？

Node.js 11.9.0, spdy 4.0.

[alexander-akait]

@yi-ge

Now using node v11.9.0 (npm v6.5.0)

can we add tests for this case and looks what CI show?

[yi-ge]

@evilebottnawi It's just a line of code.

[yi-ge]

vue cli create project.

[yi-ge]

#1592

[alexander-akait]

@yi-ge Strange, can't reproduce:

node -v
v11.9.0

Input:

const spdy = require('spdy');

console.log(spdy);

Output:

node test.js

{ handle: { [Function: Handle] create: [Function: create] },
  request: { onNewListener: [Function: onNewListener] },
  response:
   { writeHead: [Function: writeHead],
     end: [Function: end],
     push: [Function: push],
     writeContinue: [Function: writeContinue] },
  Socket: [Function: Socket],
  agent:
   { Agent: { [Function: Agent] create: [Function: create] },
     PlainAgent: { [Function: Agent] create: [Function: create] },
     create: [Function: create] },
  Agent: { [Function: Agent] create: [Function: create] },
  createAgent: [Function: create],
  server:
   { Server: { [Function: Server] create: [Function: create] },
     PlainServer: { [Function: Server] create: [Function: create] },
     create: [Function: create] },
  Server: { [Function: Server] create: [Function: create] },
  PlainServer: { [Function: Server] create: [Function: create] },
  createServer: [Function: create] }

What os you use?

[yi-ge]

@evilebottnawi MacOS. Merging code does not affect the result. You can first merge and verify. 😄

[alexander-akait]

@yi-ge So this PR doesn't solve problem?

[yi-ge]

@evilebottnawi This OR can solve the problem.

[yi-ge]

@evilebottnawi This PR, No consequences. 😄

[alexander-akait]

@yi-ge i can't understand you, i can't reproduce problem 😞 Maybe it is happens only on macos?

[yi-ge]

@evilebottnawi Only on macos, maybe. 😂

[alexander-akait]

@yi-ge looks like all works fine, i can't understand problem, please clarrify

[yi-ge]

@evilebottnawi The same code cannot be run in Mac OS node v11.1.0 +. You can see: spdy-http2/node-spdy#350 or #1592. This PR avoid this kind of situation from happening.

[alexander-akait]

@yi-ge thanks for clarify, just add comment in code with link on issue and we can merge this 👍