fix: use the host in options to check if port is available #4385
Conversation
| @@ -716,9 +717,9 @@ declare class Server { | |||
| description: string; | |||
| multiple: boolean; | |||
| path: string; | |||
| type: string; | |||
| type: string /** @type {WebSocketURL} */; | |||
There was a problem hiding this comment.
Regenerating the Server types introduces a lot unrelated comments in the type definitions, but running build:types on master does not create any diff.
There was a problem hiding this comment.
Hmm, types changed here since you added * @param {string} host
There was a problem hiding this comment.
It is bug in ts, reported about it, but still not fixed
ludofischer
requested review from
alexander-akait,
hiroppy,
knagaitsev,
snitin315 and
anshumanv
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4385 +/- ##
==========================================
+ Coverage 92.27% 92.42% +0.14%
==========================================
Files 16 16
Lines 1593 1597 +4
Branches 596 598 +2
==========================================
+ Hits 1470 1476 +6
+ Misses 114 112 -2
Partials 9 9
Continue to review full report at Codecov.
|
| @@ -406,7 +407,7 @@ class Server { | |||
| ? parseInt(process.env.WEBPACK_DEV_SERVER_PORT_RETRY, 10) | |||
| : 3; | |||
|
|
|||
| return pRetry(() => getPort(basePort), { | |||
There was a problem hiding this comment.
I am not sure retry is going to help a lot as the getPort() (and portfinder) before is going to try every port up to the maximum port number anyway, but it was introduced on purpose in this commit back in 2019, so there might be a reason.
|
Thanks |
For Bugs and Features; did you add new tests?
Yes, but it is hard to test for non-localhost hosts.
Motivation / Use-Case
The server should check if the port is available on the host specified by the user.
Breaking Changes
No breaking changes.
Additional Info