Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean Version #1189

Closed
Lutece opened this issue May 4, 2017 · 14 comments
Closed

Korean Version #1189

Lutece opened this issue May 4, 2017 · 14 comments

Comments

@Lutece
Copy link
Contributor

Lutece commented May 4, 2017

Hello, I would like to translate this page in Korean.
I would like to ask if I can translate in Korean.

I created a repository that named webpack-korea.
I connected the repository to Travis and completed it for my local environment.

I'm waiting for your answer.

@skipjack
Copy link
Collaborator

skipjack commented May 4, 2017

Awesome! There's already a chinese version maintained by @lcxfs1991 and we recently added a dropdown for languages in the main site. Once you get something solid going we could add a link in the languages dropdown:

image

Also, just so you are aware, we are considering some tools to make internationalization/translation easier, see #295.

@bebraw feel free to elaborate or add anything. From my standpoint, this would be fine as long as it's maintained in a separate repo.

@bebraw
Copy link
Contributor

bebraw commented May 4, 2017

It's alright.

@skipjack
Copy link
Collaborator

skipjack commented May 4, 2017

@Lutece can you share a link to your repo? If anyone creates issues over here or has questions re korean translation, we can send them over to your repository. Also, you may want to get some ideas from @lcxfs1991 as their chinese repository is already pretty far along. He can discuss our translation branch a bit, which may be useful to you as well.

@Lutece
Copy link
Contributor Author

Lutece commented May 5, 2017

This is korean repo link :) - https://github.com/webpack-korea/webpack.js.org

Should I use Locki when I translate webpack.org?

Could you please explain how to proceed with the translation?

@lcxfs1991
Copy link
Collaborator

Hi Lutece, I am willing to help.

Locki is needed more work to be integrated into the main repo.

You can take a look at branch translate. You can arrange friends to help translate first. Any questions you can raise issue here or directly contact me via Twitter Message.

https://twitter.com/lcxfs1991

@skipjack
Copy link
Collaborator

skipjack commented May 5, 2017

Should I use Locki when I translate webpack.org?

Not yet, as @lcxfs1991 said, the Locki setup probably won't be for a bit. Just wanted you to be aware, and might be worth subscribing to the issue (#295).

Could you please explain how to proceed with the translation?

What you proposed, as in maintaining a separate repo, would be fine for now. Past that, I would discuss with @lcxfs1991. I'll leave this issue open for a few more days in case you'd like to discuss more here. Also, I may add a translation section to the readme with links to each of your repositories.

@skipjack
Copy link
Collaborator

skipjack commented May 7, 2017

Closing this, but I will add a translation/internationalization section to the readme with links to both repos. And, once the korean version is significantly built out, we'll add a link to wherever you decide to host it.

@skipjack skipjack closed this as completed May 7, 2017
@Lutece
Copy link
Contributor Author

Lutece commented May 10, 2017

@lcxfs1991 @skipjack Thank you for answering me.
I started to translate to Korean, so when I finished translate, I'll inform you.

I'll be back to here soon!

@lcxfs1991
Copy link
Collaborator

@Lutece Good luck man. It'd better ask more friends to join you.

@mojosoeun
Copy link

mojosoeun commented Jun 13, 2017

@Lutece Hi, Lutece. I want to contribute the korean translation project! Could I join the project?

@Lutece
Copy link
Contributor Author

Lutece commented Jun 14, 2017

@mojosoeun Sure! I sent you an email for the invitation and i made a slack channel for webpack-korea. if you want to talk to me any time, please join the slack channel

@mojosoeun
Copy link

@Lutece OO Thank you :)

@Lutece
Copy link
Contributor Author

Lutece commented Jun 22, 2017

@skipjack, @lcxfs1991 I have a few question about Webpack version.

Translation branch is still version 2.3.3 and my repository is watching translation branch. so my version is 2.3.3 too, how can I change version 2.3.3 to version 3.0.0?

Do I need to update to 3.0.0 after I finish 2.3.3 version?

@skipjack
Copy link
Collaborator

Hmmm so what do you mean by:

Translation branch is still version 2.3.3

Do you mean the version number in the sidebar:

image

That's dynamic now so if you update your fork it should basically always be on the latest version. One of you could also PR an update to the translation branch if it's behind. @lcxfs1991 @bebraw could probably give you slightly better advice since I'm still not exactly sure what the translation workflow is.

You could also keep your fork a little behind and wait for things to stabilize a bit before updating -- meaning things are still changing quite rapidly (for example all the guides cleanup in #1258) so you might end up having to update the translations a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants