Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev - Large Bundles Affecting Load Time #1786

Closed
lcxfs1991 opened this issue Jan 13, 2018 · 4 comments
Closed

Dev - Large Bundles Affecting Load Time #1786

lcxfs1991 opened this issue Jan 13, 2018 · 4 comments

Comments

@lcxfs1991
Copy link
Collaborator

lcxfs1991 commented Jan 13, 2018

image

image

I think it is due to recent change. But it would be better to reduce bundle size. Otherwise, it is a pressure for developers with slow network to load the doc site.

@lcxfs1991
Copy link
Collaborator Author

I also spot some unuseful code in some pages:

image

image

@lcxfs1991
Copy link
Collaborator Author

what's you guys opinions? @skipjack @TheLarkInn

@skipjack
Copy link
Collaborator

I'm not able to replicate:

image

What branch are you on and what page of the site are you on? The rebuild branch isn't complete so large build sizes are to be expected. In the screenshot I shared above one of the bundles is slightly too big but there's already mention of that in #1525 and will should be addressed by the rebuild. Closing but feel free to share more details and I'll take another look.

@skipjack skipjack changed the title The docs is too huge to load and maintain Dev - Large Bundles (Long Load Time) Jan 14, 2018
@skipjack skipjack changed the title Dev - Large Bundles (Long Load Time) Dev - Large Bundles Affecting Load Time Jan 14, 2018
@skipjack
Copy link
Collaborator

On the chinese site, I am able to replicate however:

image

Did someone alter the webpack or antwar config over on that repo? Maybe react and react-dom aren't being replaced by preact in production? We don't officially support the other forks so this issue might make sense over there... I'm not sure how much time I'll have to help debug but you may be able to grab some other help from our slack channel or @bebraw (author of antwar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants