Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(getting-started): refine module section #1450

Merged
merged 3 commits into from
Jul 25, 2017
Merged

docs(getting-started): refine module section #1450

merged 3 commits into from
Jul 25, 2017

Conversation

simon04
Copy link
Collaborator

@simon04 simon04 commented Jul 21, 2017

  • bring together related sentences
  • add links to further documentation

@simon04
docs(getting-started): refine module section
4121657 
* bring together related sentences
* add links to further documentation
@simon04 simon04 force-pushed the getting-started-modules branch from a596a21 to 4121657 Compare July 21, 2017 06:59
@TheDutchCoder TheDutchCoder self-requested a review July 22, 2017 21:16
TheDutchCoder
TheDutchCoder approved these changes Jul 22, 2017
View reviewed changes
Copy link
Collaborator

@TheDutchCoder TheDutchCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skipjack
Copy link
Collaborator

I have a fix for the build errors in #1436. It was caused by a change to the uglifyjs plugin's readme. I'll try to get that one and a few others, including this, in tomorrow.

@skipjack
Copy link
Collaborator

There's a minor markdown linting issue we need to fix and then this should be good to go. We should either extend the allowed line length in that rule or break up that paragraph. This is another instance where reference links would be nice as I think those characters get counted.

@skipjack skipjack merged commit 4a23ad0 into webpack:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skipjack skipjack skipjack approved these changes

@TheDutchCoder TheDutchCoder TheDutchCoder approved these changes

Assignees
No one assigned
Labels
Enhancement Guides
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon04 @skipjack @TheDutchCoder