Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config): style update to webkit scroll bars #1626

Closed

Conversation

rouzbeh84
Copy link
Collaborator

I tried pulling this against refactor-info-architecture but couldn't since changes didn't effect the branch. All this does is add a webkit scrollbar style to hide it as mentioned in this comment about the proximity of content to scroll bars.

this should only get looked at after #1612 is merged in.

NOTE:
this does not fix it for FF/IE as those browsers do not support this behavior. an alternative would be to add padding to both .sidebar__inner and .page__content

skipjack and others added 14 commits September 29, 2017 00:09
This commit contains the following changes:

- Merge support and development into a coherent "Contribute" section.
- Flatten `/api/plugins` in preparation for flattened page `group`ing.
- Sort "Contribute" section and rewrite index page using "Why Support?".
- Simplify and organize antwar config as much as possible.
- Move `title` / `description` fields to the actual components.

BREAKING CHANGE: The route restructuring and content reorg
breaks some routes. Before this is merged, we should make sure
to add redirects for anything broken.
Simplify routing to reflect antwar and content changes and remove
extraneous links. Simplify styling to first improve the design, but also
to provide a lot more breathing room so less hacks are needed for
smaller page sizes. With the updated design we should have room
for "Voting" and "Analyze" links once those micro apps are in a
better place.
"Support" is now included in the "Contribute" section and already has
a link in the top navigation. The starter-kits page was previously hidden
from users, so this exposes it a bit more.
Make minor styling change for consistent gutter. Extract link data into
a separate JSON file. Update variable and parameter names for clarity.
Add support for a new `group` field in each page's YAML frontmatter to
group pages together in an intuitive way. The benefit of this approach vs
directories is that changing a pages group within the same top-level section
won't affect its route and thus will not break links to it.
@skipjack skipjack force-pushed the refactor-info-architecture branch from 84697bc to 9b64f96 Compare October 11, 2017 03:55
@rouzbeh84
Copy link
Collaborator Author

rouzbeh84 commented Oct 11, 2017

crosspost from #1612

chrome

firefox

@skipjack skipjack closed this Oct 11, 2017
@skipjack skipjack deleted the hotfix/hide-webkit-scrollbar branch October 11, 2017 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants