Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop buffer #465

Merged
merged 1 commit into from
May 26, 2023
Merged

fix: drop buffer #465

merged 1 commit into from
May 26, 2023

Conversation

ThaUnknown
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
this PR drops buffer for uint8 in as many places as it's reasonable, mainly for client only, since using buffer on server is fine, tho i did replace buffer with uint8 in server in some places, dropped a few dependencies to do this which is nice too

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: [email protected]

@ThaUnknown ThaUnknown enabled auto-merge (squash) May 26, 2023 14:01
Copy link
Member

@SilentBot1 SilentBot1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested and working with multiple clients (UDP, TCP and WSS).

@ThaUnknown ThaUnknown merged commit c99eb89 into webtorrent:master May 26, 2023
webtorrent-bot pushed a commit that referenced this pull request May 26, 2023
## [10.0.4](v10.0.3...v10.0.4) (2023-05-26)

### Bug Fixes

* drop buffer ([#465](#465)) ([c99eb89](c99eb89))
@webtorrent-bot
Copy link

🎉 This PR is included in version 10.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ThaUnknown ThaUnknown deleted the buffer branch May 26, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants