Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to specify host #7

Closed
tomasc opened this issue Jun 13, 2017 · 5 comments
Closed

ability to specify host #7

tomasc opened this issue Jun 13, 2017 · 5 comments
Milestone

Comments

@tomasc
Copy link

tomasc commented Jun 13, 2017

Useful when running Chrome in a separate Docker container.

I tried to hack it in (https://github.com/tomasc/html-pdf-chrome/commit/966ef4b0e6896c5cb33740e4f3481c035c2e2b0e), but not familiar with JS development so not sure how to update tests etc. in order to make proper PR.

@westy92 westy92 modified the milestone: v0.2.0 Jun 13, 2017
@tomasc
Copy link
Author

tomasc commented Jun 14, 2017

Thank you!

@westy92
Copy link
Owner

westy92 commented Jun 14, 2017

You're welcome. I'm pushing off the release until I can finish up the other feature request. For now, you should be able to use the specific commit hash in your project.

@tomasc
Copy link
Author

tomasc commented Jun 14, 2017

Great, I look forward to the next release with the timeout. If you need any help, please let me know.

@westy92
Copy link
Owner

westy92 commented Jul 14, 2017

Released in v0.2.0!

@tomasc
Copy link
Author

tomasc commented Jul 14, 2017

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants