From aa0c939994c495c2e246925dcd1f84ae7d36df6a Mon Sep 17 00:00:00 2001 From: Dmitry Brant Date: Mon, 19 Aug 2024 13:47:02 -0400 Subject: [PATCH] Re-enable preBeta feature flag for MGAD. (#4877) * Re-enable preBeta feature flag for MGAD. * Add one more check. * Temporarily remove en from language list. --- .../org/wikipedia/descriptions/DescriptionEditFragment.kt | 6 +++++- .../wikipedia/views/SuggestedArticleDescriptionsDialog.kt | 3 ++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/wikipedia/descriptions/DescriptionEditFragment.kt b/app/src/main/java/org/wikipedia/descriptions/DescriptionEditFragment.kt index b753f59500a..30e3435c9b0 100644 --- a/app/src/main/java/org/wikipedia/descriptions/DescriptionEditFragment.kt +++ b/app/src/main/java/org/wikipedia/descriptions/DescriptionEditFragment.kt @@ -53,8 +53,10 @@ import org.wikipedia.suggestededits.SuggestedEditsSurvey import org.wikipedia.suggestededits.SuggestionsActivity import org.wikipedia.util.DeviceUtil import org.wikipedia.util.FeedbackUtil +import org.wikipedia.util.ReleaseUtil import org.wikipedia.util.StringUtil import org.wikipedia.util.log.L +import org.wikipedia.views.SuggestedArticleDescriptionsDialog import java.io.IOException import java.util.Date import java.util.concurrent.TimeUnit @@ -219,7 +221,9 @@ class DescriptionEditFragment : Fragment() { binding.fragmentDescriptionEditView.setEditAllowed(editingAllowed) binding.fragmentDescriptionEditView.updateInfoText() - binding.fragmentDescriptionEditView.isSuggestionButtonEnabled = true + binding.fragmentDescriptionEditView.isSuggestionButtonEnabled = ReleaseUtil.isPreBetaRelease && + SuggestedArticleDescriptionsDialog.availableLanguages.contains(pageTitle.wikiSite.languageCode) && + binding.fragmentDescriptionEditView.description.isNullOrEmpty() if (binding.fragmentDescriptionEditView.isSuggestionButtonEnabled) { binding.fragmentDescriptionEditView.showSuggestedDescriptionsLoadingProgress() diff --git a/app/src/main/java/org/wikipedia/views/SuggestedArticleDescriptionsDialog.kt b/app/src/main/java/org/wikipedia/views/SuggestedArticleDescriptionsDialog.kt index 92aaedbd2fa..7dd22136e04 100644 --- a/app/src/main/java/org/wikipedia/views/SuggestedArticleDescriptionsDialog.kt +++ b/app/src/main/java/org/wikipedia/views/SuggestedArticleDescriptionsDialog.kt @@ -64,8 +64,9 @@ class SuggestedArticleDescriptionsDialog( } companion object { + // TODO: reenable 'en' when ready. val availableLanguages = listOf( - "en", "ru", "vi", "ja", "de", "ro", "fr", "fi", "ko", "es", "zh", "it", + "ru", "vi", "ja", "de", "ro", "fr", "fi", "ko", "es", "zh", "it", "nl", "ar", "tr", "hi", "cs", "lt", "lv", "kk", "et", "ni", "si", "gu", "my" ) }