Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the integrity of components coming from channels #112

Closed
jmesnil opened this issue Oct 21, 2022 · 0 comments · Fixed by #268 · May be fixed by #134
Closed

Verify the integrity of components coming from channels #112

jmesnil opened this issue Oct 21, 2022 · 0 comments · Fixed by #268 · May be fixed by #134

Comments

@jmesnil
Copy link
Member

jmesnil commented Oct 21, 2022

When a component is installed from a stream, we should have a way to verify its integrity.

We could add a sha256checksum that would be verify when the corresponding artifact is downloaded to verify that its content has not been modified.
This is only possible if a fixed version is defined and would not make sense with versionPattern.

The checksum is also tied to the type and classifier of artifacts retrieved (eg Galleon pack would need to verify their zip package) while jar dependencies would verify their jar package. A single GA can define multiple artifacts thanks to the classifier, classifier, if any, is taken into account as [classifier/]extension in the key.

streams:
  - groupId: org.wildfly
    artifactId: wildfly-galleon-pack
    version: 26.0.0.Final
    sha256checksum:
      zip: d06591ac1fa5871258a574abcd4cc06f8be28ad1
  - groupId: org.wildfly.core
     artifactId: wildfly-controller
     version:19.0.0.Final
     sha256checksum:
       jar: 1cdc99e86a0002d111e7e41cc6989ca83624cd62
  - groupId: org.wildfly.core
     artifactId: wildfly-cli
     version:19.0.0.Final
     sha256checksum:
       jar: 1cdc99e86a0002d111e7e41cc6989ca83624cd62
       client/jar: 2adc99e86a0002d111e7e41cc6989ca83624cd98
  • If the sha256checksum section is not present (or there is no value for the given package type), the integrity of the component will not be verified.
  • If version is not present and the sha256checksum is present, an error will be reported.
@jmesnil jmesnil changed the title Add a sha1checksum field to the stream to verify the integrity of downloads Add a sha256checksum field to the stream to verify the integrity of downloads Oct 21, 2022
jmesnil added a commit to jmesnil/wildfly-channel that referenced this issue Oct 21, 2022
This fixes wildfly-extras#112.

Signed-off-by: Jeff Mesnil <[email protected]>
jmesnil added a commit to jmesnil/wildfly-channel that referenced this issue Oct 21, 2022
This fixes wildfly-extras#112.

Signed-off-by: Jeff Mesnil <[email protected]>
@jmesnil jmesnil changed the title Add a sha256checksum field to the stream to verify the integrity of downloads Verify the integrity of components coming from channels Nov 16, 2022
jfdenise pushed a commit to jfdenise/wildfly-channel that referenced this issue Jan 24, 2023
This fixes wildfly-extras#112.

Signed-off-by: Jeff Mesnil <[email protected]>

Conflicts:
	core/src/main/java/org/wildfly/channel/Channel.java
	core/src/main/java/org/wildfly/channel/ChannelSession.java
jfdenise pushed a commit to jfdenise/wildfly-channel that referenced this issue Jan 25, 2023
This fixes wildfly-extras#112.

Signed-off-by: Jeff Mesnil <[email protected]>

Conflicts:
	core/src/main/java/org/wildfly/channel/Channel.java
	core/src/main/java/org/wildfly/channel/ChannelSession.java
jfdenise pushed a commit to jfdenise/wildfly-channel that referenced this issue Feb 14, 2023
This fixes wildfly-extras#112.

Signed-off-by: Jeff Mesnil <[email protected]>

Conflicts:
	core/src/main/java/org/wildfly/channel/Channel.java
	core/src/main/java/org/wildfly/channel/ChannelSession.java
jmesnil added a commit that referenced this issue Dec 19, 2024
[#112] Enable GPG checks of channel artifacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant