Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<CR> opens unlisted buffer in a new split #317

Closed
mkhl opened this issue Nov 14, 2017 · 4 comments
Closed

<CR> opens unlisted buffer in a new split #317

mkhl opened this issue Nov 14, 2017 · 4 comments

Comments

@mkhl
Copy link

mkhl commented Nov 14, 2017

I believe this is also fixed by #315, but even if it's just another repro…

  1. Populate the quickfix list, say using :grep
  2. :CommandT
  3. Find a file that has a match in the quickfix list

Command-T opens a nobuflisted buffer with the file in a new split (instead of opening a “regular” buffer in the current window).

@tap349
Copy link
Contributor

tap349 commented Nov 14, 2017

@mkhl With that fix applied file is opened inside quickfix window (since it's the last focused window). Is it correct behaviour from your point of view?

@mkhl
Copy link
Author

mkhl commented Nov 14, 2017

@tap349 After :grep I still have focus on the window that had it before, and command-t opens files there.
If I move focus to the quickfix window then I think opening files there if fine.

@wincent
Copy link
Owner

wincent commented Nov 17, 2017

I think this might be long-standing behavior, to avoid awkward things happening like, for example, opening a file in a very narrow special buffer like NERDTree when focused.

But having said that, even if that is the intention, the behavior when the quickfix window is focused is not very consistent, because the behavior you describe only happens when you open a file that has a match in the list (which is decidedly odd).

@wincent
Copy link
Owner

wincent commented Nov 17, 2017

Tried it out with #315 (landed to the master branch) and the behavior seems to be reasonable. Going to close this, but please comment if you'd like to discuss further and I can re-open it.

@wincent wincent closed this as completed Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants