Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Commandline command doesn't tangle drupal #9

Open
generalredneck opened this issue Jan 9, 2015 · 2 comments
Open

Using Commandline command doesn't tangle drupal #9

generalredneck opened this issue Jan 9, 2015 · 2 comments

Comments

@generalredneck
Copy link

I'm not 100% sure if this works by design since it's out of the context of composer running, however, I'm trying to do the following ./vendor/bin/drupal_tangle . www. This seems to me to be the equivilant to the defaults where are set here. When I do that, I get a www folder filled out with a sites/default folder and the vendor symlink. Do you have any idea why when I run just flat out ./vendor/bin/drupal_tangle that I get a full build vs that?

@generalredneck
Copy link
Author

When I print out the map generated by the two, the difference is that one has a full path and the other has a relative path

Using ./vendor/bin/drupal_tangle . new

array(9) {
  ["core"]=>
  array(1) {
    ["/var/www/sites/martincounty.dev/vendor/drupal/drupal"]=>
    string(35) "/var/www/sites/martincounty.dev/new"
  }
  ["module"]=>
  array(52) {
    ["/var/www/sites/martincounty.dev/vendor/drupal/ctools"]=>
    string(68) "/var/www/sites/martincounty.dev/new/sites/all/modules/contrib/ctools"
    ["/var/www/sites/martincounty.dev/vendor/drupal/views"]=>
    string(67) "/var/www/sites/martincounty.dev/new/sites/all/modules/contrib/views"
    ["/var/www/sites/martincounty.dev/vendor/drupal/variable"]=>
    string(70) "/var/www/sites/martincounty.
    ...

vs

Using ./vendor/bin/drupal_tangle

array(9) {
  ["core"]=>
  array(1) {
    ["vendor/drupal/drupal"]=>
    string(35) "/var/www/sites/martincounty.dev/www"
  }
  ["module"]=>
  array(52) {
    ["vendor/drupal/ctools"]=>
    string(68) "/var/www/sites/martincounty.dev/www/sites/all/modules/contrib/ctools"
    ["vendor/drupal/views"]=>
    string(67) "/var/www/sites/martincounty.dev/www/sites/all/modules/contrib/views"
    ["vendor/drupal/variable"]=>
    string(70) "/var/www/sites/martincounty.dev/www/sites/all/modules/contrib/variable"
   ...

@generalredneck
Copy link
Author

Ok there were a couple of issues here.

  1. the commandline wouldn't take full paths.
  2. Symfony's makePathRelative function seems to have issues with the directory .
  3. I had to make tangler distiguish between full paths and relative paths, because you would get full paths if you didn't use the default options.

I accidently made the changes to my PHP5.3 patch... so here's that. We will need to make the changes in a 5.4+ way later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant