Limit @autoupdate directive executions
#3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some warning reporting to autoupdate directive Annotate directive_handlers (doesn't really work :P)
@autoupdate is still ignored beyond 1 instance
|
They said it crashes server too. Why the fix only being done for client? |
|
I think you may have misread the code. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3190. In addition, I made this directive a little more informative. Unrelated to the linked issue, I also included some wrapping into the E2 editor to avoid the editor from failing to close (such failures are rare but extremely annoying).
Relevant changes:
@autoupdatedirective to only ever run once@autoupdateis defined twice in the same fileMiscellaneous changes:
@autoupdateis passed any argumentsValidate, but I wrapped a few other functions to be on the safe side