Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea to refactor number code #45

Closed
clach04 opened this issue Jan 10, 2024 · 1 comment
Closed

Idea to refactor number code #45

clach04 opened this issue Jan 10, 2024 · 1 comment

Comments

@clach04
Copy link

clach04 commented Jan 10, 2024

Related to:

  1. comment Add preliminary Ingres/Vector/Actian Avalanche support #36 (comment)
  2. change / commit 4f8ad30

Idea / Proposal / Question

if isinstance(column.data_type, agate.Number) and dialect in ('ingres', 'mssql', 'mysql', 'oracle'):

Change the include list check to an exclude list. Looking at the code, sounds like PostgreSQL and SQLite could be an exclude list, and maybe easier to maintain.

            if isinstance(column.data_type, agate.Number) and dialect not in ('postgresql', 'sqlite'):
@jpmckinney
Copy link
Member

As far as maintenance goes, it’s the same to me whether we include or exclude. What’s important is to document the precision ranges, so that we set a valid default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants