You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change the include list check to an exclude list. Looking at the code, sounds like PostgreSQL and SQLite could be an exclude list, and maybe easier to maintain.
if isinstance(column.data_type, agate.Number) and dialect not in ('postgresql', 'sqlite'):
The text was updated successfully, but these errors were encountered:
As far as maintenance goes, it’s the same to me whether we include or exclude. What’s important is to document the precision ranges, so that we set a valid default.
Related to:
Idea / Proposal / Question
agate-sql/agatesql/table.py
Line 215 in d2bd282
Change the include list check to an exclude list. Looking at the code, sounds like PostgreSQL and SQLite could be an exclude list, and maybe easier to maintain.
The text was updated successfully, but these errors were encountered: