HMR: Installing sass when in error state does not reload page

[matthewp]

What version of astro are you using?

1.5.2

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Mac

Describe the Bug

1. Do not install sass.
2. Add lang="scss" to a style attribute.
3. You will get an error.
4. npm install sass
5. Should reload the browser, does not. Reloading manually fixes it.

Link to Minimal Reproducible Example

n/a

Participation

• I am willing to submit a pull request for this issue.

[matthewp]

This is blocked by this Node core bug: nodejs/node#44663

[bluwy]

I think it would be cool if this works, but I'm not sure if Vite currently works when installing packages on the fly too. Traditionally whenever installing or updating a package, it would be safer to reboot everything.

[matthewp]

Vite would work in this case if not for the Node core bug. Another alternative is to launch Astro as a subprocess and to kill that subprocess on any package.json changes. That would be heavy, however.

[matthewp]

Another solution being discussed is installing sass when it is attempted to be used, see https://discord.com/channels/804011606160703521/1037805603956998304.

[matthewp]

Assigning to @bluwy who's going to update Vite to first check if the package exists before trying to require it.

[bluwy]

Ref Vite PR: vitejs/vite#10812. Still needs to be cherry-picked into the Vite v3 branch and released before we can make the change here.

[bluwy]

The fix is released in Vite 3.2.4 👍