fix(routing): don't attach locals to request

[ematipico]

Changes

This PR refactors how we internally handle the locals. The use of the symbol on Request has been limited only to the dev server, because that's the only way for adapters to send us locals in dev.

Technically, this isn't a breaking change for the adapters because the App.render function already provides the APIs for passing initial locals. Plus, the RenderContext class already holds the locals when it's created, so it's safe to remove the places where Reflect.set/Reflect.get is used.

The only place where we need to keep the Request usage is a runtime, public API called createContext, which is only used my the edge middleware.

Testing

The CI should pass

Docs

N/A

[changeset-bot]

⚠️ No Changeset found

Latest commit: 902a3a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #12647 will not alter performance

_{Comparing fix/symbol-locals (902a3a1) with main (e216250)}

Summary

✅ 4 untouched benchmarks