Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused imports #12696

Merged
merged 10 commits into from
Dec 11, 2024
Merged

Conversation

florian-lefebvre
Copy link
Member

Changes

  • Internal refactor, no changeset

Testing

Tests should still pass

Docs

Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: 6129662

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 9, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #12696 will not alter performance

Comparing chore/remove-unused-imports (6129662) with main (b3dfd9b)

Summary

✅ 4 untouched benchmarks

@florian-lefebvre
Copy link
Member Author

I used this rule locally, I know linter things can be... controversial 😅 so I didn't want to enable the rule. But I'd be in favor of enabling it

@ematipico
Copy link
Member

ematipico commented Dec 9, 2024

controversial 😅

You can enable it as warning of info, so it doesn't block the CI

@florian-lefebvre
Copy link
Member Author

Looks like the build command had an unused argument and dep

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Dec 9, 2024
@florian-lefebvre florian-lefebvre merged commit 110fc01 into main Dec 11, 2024
16 checks passed
@florian-lefebvre florian-lefebvre deleted the chore/remove-unused-imports branch December 11, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants