Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim project name of the user input #8427

Merged
merged 4 commits into from
Sep 6, 2023
Merged

trim project name of the user input #8427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3be7180
fix: remove duplicate import
aswind7 Sep 4, 2023
66ff27d
Merge branch 'withastro:main' into main
aswind7 Sep 6, 2023
dfadc6b
project name should be trimed
aswind7 Sep 6, 2023
a6a7299
update changeset
aswind7 Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eighty-gifts-speak.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-astro': patch
---

trim project name of the user input
2 changes: 1 addition & 1 deletion packages/create-astro/src/actions/project-name.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export async function projectName(ctx: Pick<Context, 'cwd' | 'prompt' | 'project
},
});

ctx.cwd = name!;
ctx.cwd = name!.trim();
ctx.projectName = toValidName(name!);
} else {
let name = ctx.cwd;
Expand Down
9 changes: 9 additions & 0 deletions packages/create-astro/test/project-name.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@ describe('project name', () => {
expect(context.projectName).to.eq('foobar');
});


it('blank space', async () => {
const context = { projectName: '', cwd: '', prompt: () => ({ name: 'foobar ' }) };
await projectName(context);

expect(context.cwd).to.eq('foobar');
expect(context.projectName).to.eq('foobar');
});

it('normalize', async () => {
const context = { projectName: '', cwd: '', prompt: () => ({ name: 'Invalid Name' }) };
await projectName(context);
Expand Down
Loading