Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update integration docs #4494

Merged
merged 2 commits into from
Sep 11, 2023
Merged

ci: update integration docs #4494

merged 2 commits into from
Sep 11, 2023

Conversation

astrobot-houston
Copy link
Contributor

This PR is auto-generated by a nightly GitHub action to update the individual integration pages from the integration READMEs in withastro/astro.

@astrobot-houston astrobot-houston added the ci Automated PRs created by CI, or PRs about automation - ask @delucis for help! label Sep 1, 2023
@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 5d018a0
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/64fe5b63a9e3d80009264b17
😎 Deploy Preview https://deploy-preview-4494--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the bad changes that were converting GET() back to get(). Should be good to merge now.

delucis
delucis previously requested changes Sep 2, 2023
@@ -170,7 +170,7 @@ See Cloudflare's documentation for [working with environment variables](https://
```js
// pages/[id].json.js

export function GET({ params }) {
export function get({ params }) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh this looks wrong again. Something to tackle next week 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have created withastro/astro#8429 to fix this at the source.

@astrobot-houston astrobot-houston force-pushed the ci/docgen-integrations branch 6 times, most recently from 94f8e29 to 6da1db9 Compare September 9, 2023 12:04
@sarah11918 sarah11918 dismissed delucis’s stale review September 11, 2023 00:15

issue was fixed at source!

@sarah11918 sarah11918 merged commit e984390 into main Sep 11, 2023
10 checks passed
@sarah11918 sarah11918 deleted the ci/docgen-integrations branch September 11, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Automated PRs created by CI, or PRs about automation - ask @delucis for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants