Bug fixed - the UIScrollView will break on iOS10 when building by XCode9 #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only happens when you are using [email protected], and your XCode is in version 9.0
|
I had that problem w/ XCode9 and react-native 0.46.3 so it does not only happen on 0.48.3 |
|
Can anyone please merge this ? |
gran33
approved these changes
Sep 24, 2017
|
Thanks man! |
junedomingo
pushed a commit
to junedomingo/react-native-navigation
that referenced
this pull request
Sep 29, 2017
…de9 (wix#1896) This only happens when you are using [email protected], and your XCode is in version 9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only happens when you are using [email protected], and build your APP by XCode9. When you run your APP in iOS10 or below, it will throw
unrecognized selectorerror. The new iOS11 has new design on StatusBar which behaves weird on UIScrollView, so that the react-native team added this new selector to fix it. This PR will help to address this problem when you are also using the amazingreact-native-navigation.Here's the error details:
Reference:
facebook/react-native#15957
https://github.com/wix/react-native-navigation/issues/1886