Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

WooCommerce 7.9 still causing Site Editor Navigation malfunction WP 6.2/WP 6.3RC3 even with Woo Blocks 10.8.0 #10467

Closed
Marc-pi opened this issue Aug 3, 2023 · 13 comments · Fixed by #10475
Labels
type: bug The issue/PR concerns a confirmed bug. type: community contribution

Comments

@Marc-pi
Copy link

Marc-pi commented Aug 3, 2023

On 2 of my sites, using FSE only, i've an issue at editing Navigation component aka Menus, willing to edit them leads to Black Screen of Death.

Follow up to #10259

the issue is still there, and it is critical (we cannot manage our menus)

ping @nefeline / @nerrad

How to get the issue

  1. Go to Site Editor wp-admin/site-editor.php
  2. Click on Navigation
  3. Click on the arrow on the navigation menu you want to edit
  4. You get a black screen of death :-)

If you inactive WooCommerce plugin, the error is gone
If you inactive only Woo Block, the error is still there

so the error is brought by WooCommerce

Environment
Both sites run Gutenberg 16.3.0 + WooCommerce 7.9.0 + Woo Blocks 10.8.0
and are under PHP 8.1.16
the only difference is the WP Version and the theme in use

  • WP 6.2.2 + TT3
  • WP 6.3RC3 + TT2
@Marc-pi Marc-pi added the type: bug The issue/PR concerns a confirmed bug. label Aug 3, 2023
@Marc-pi Marc-pi changed the title WooCommerce 7.9 still causing navigation Site Editor malfunction WP 6.2/WP 6.3RC3 even with Woo Blocks 10.8.0 WooCommerce 7.9 still causing Site Editor Navigation malfunction WP 6.2/WP 6.3RC3 even with Woo Blocks 10.8.0 Aug 3, 2023
@Marc-pi
Copy link
Author

Marc-pi commented Aug 3, 2023

seems a fix was shipped into a WC Blocks 10.6.2 and into WooCommerce Trunk, but not in 10.8.0 !!!
ping @gigitux
seems not to be yet in 8.0 RC !

@gigitux
Copy link
Contributor

gigitux commented Aug 3, 2023

Hi @Marc-pi,

I tested the release 10.8.0 with WordPress 6.2 with the last version of Gutenberg installed and I'm unable to reproduce the issue.

seems not to be yet in 8.0 RC !

WC Blocks 10.6.2 is included in the WooCommerce 8.0 RC-1.

Can you share which env gives you the issue? Thanks!

@Marc-pi
Copy link
Author

Marc-pi commented Aug 3, 2023

Can you share which env gives you the issue? Thanks!

of course, it is in my first post. Tell me if you need more.

WC Blocks 10.6.2 is included in the [WooCommerce 8.0 RC-1

ok, i was looking for it the changelog entry on a dedicated line, it is indeed in the 10.6.2 line
https://github.com/woocommerce/woocommerce/blob/release/8.0/plugins/woocommerce/readme.txt
my mistake

@gigitux
Copy link
Contributor

gigitux commented Aug 3, 2023

I tested the release 10.8.0 with WordPress 6.2 with the last version of Gutenberg installed and I'm unable to reproduce the issue.

Same result with WordPress 6.3-RC3.

Are you sure that you are using WooCommerce Blocks 10.8.0?

@Marc-pi
Copy link
Author

Marc-pi commented Aug 3, 2023

Are you sure that you are using WooCommerce Blocks 10.8.0?

yep, i do confirm i run 10.8.0

image

image

but i did not notice you've commited the fix into 10.8.0 as well, no ? Only into 10.6.x and woo trunk

@gigitux
Copy link
Contributor

gigitux commented Aug 3, 2023

I can confirm that the fix is in 10.8.0. If you check the branch release/10.8.0, you can see that the changes done into woocommerce/woocommerce#10388 are present.

Can you open the console of dev tools and check if there is an error?

@Marc-pi
Copy link
Author

Marc-pi commented Aug 3, 2023

yep, i've noticed i've some this afternoon.
FYI i do use Firefox 116 (latest stable), but i've also the bug on Chrome latest (black screen)

  • when accessing wp-admin/site-editor.php
    image
    those are coming from WP Core as long as i saw

  • when clicking on menu to edit it, on wp-admin/site-editor.php?postId=128&postType=wp_navigation
    i've many more similar with "e.split is not a function"

image

image

@gigitux
Copy link
Contributor

gigitux commented Aug 4, 2023

Did you have Gutenberg installed? If yes, can you try to disable it? Maybe it is another issue: WordPress/gutenberg#53230

@nefeline
Copy link
Contributor

nefeline commented Aug 4, 2023

Thanks for the report @Marc-pi & for jumping on this @gigitux !

I can confirm the error is triggered in the site editor while having GB 16.3 enabled.

Disabling GB solves the problem. Seems to be related to WordPress/gutenberg#53230 indeed.

@Marc-pi
Copy link
Author

Marc-pi commented Aug 4, 2023

whoever fixes this issue can also close 2 tickets for the same price :-)
another one is there #10628

@gigitux
Copy link
Contributor

gigitux commented Aug 4, 2023

another one is there #10628

I will write a comment on this issue! Thanks for sharing the link!

@Marc-pi
Copy link
Author

Marc-pi commented Aug 7, 2023

@gigitux just to thank you, works like a charm with 10.8.1 release

@gigitux
Copy link
Contributor

gigitux commented Aug 7, 2023

@gigitux just to thank you, works like a charm with 10.8.1 release

Thanks for your feedback!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug. type: community contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants