Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble retrieving English names for South African provinces #7

Open
respencer opened this issue Feb 20, 2024 · 3 comments
Open

Trouble retrieving English names for South African provinces #7

respencer opened this issue Feb 20, 2024 · 3 comments

Comments

@respencer
Copy link

For some reason I have yet to figure out, the English names for South African provinces aren't being consistently retrieved:

iso-3166/2.js

Lines 25208 to 25252 in 7aacab6

{
code: 'ZA-EC',
name: 'Kapa-Vuxa',
parent: 'ZA'
},
{
code: 'ZA-FS',
name: 'Free State',
parent: 'ZA'
},
{
code: 'ZA-GP',
name: 'Gauteng',
parent: 'ZA'
},
{
code: 'ZA-KZN',
name: 'Kwazulu-Natal',
parent: 'ZA'
},
{
code: 'ZA-LP',
name: 'Limpopo',
parent: 'ZA'
},
{
code: 'ZA-MP',
name: 'Mpumalanga',
parent: 'ZA'
},
{
code: 'ZA-NC',
name: "Kapa-N'walungu",
parent: 'ZA'
},
{
code: 'ZA-NW',
name: "N'walungu-Vupeladyambu",
parent: 'ZA'
},
{
code: 'ZA-WC',
name: 'Kapa-Vupeladyambu',
parent: 'ZA'
},

For reference it should be:

  {
    code: 'ZA-EC',
    name: 'Eastern Cape',
    parent: 'ZA'
  },
  {
    code: 'ZA-FS',
    name: 'Free State',
    parent: 'ZA'
  },
  {
    code: 'ZA-GP',
    name: 'Gauteng',
    parent: 'ZA'
  },
  {
    code: 'ZA-KZN',
    name: 'Kwazulu-Natal',
    parent: 'ZA'
  },
  {
    code: 'ZA-LP',
    name: 'Limpopo',
    parent: 'ZA'
  },
  {
    code: 'ZA-MP',
    name: 'Mpumalanga',
    parent: 'ZA'
  },
  {
    code: 'ZA-NC',
    name: 'Northern Cape',
    parent: 'ZA'
  },
  {
    code: 'ZA-NW',
    name: 'North-West',
    parent: 'ZA'
  },
  {
    code: 'ZA-WC',
    name: 'Western Cape',
    parent: 'ZA'
  },
@wooorm
Copy link
Owner

wooorm commented Feb 20, 2024

Very possible. Wikipedia is contributor based. The data there probably looks different from other countries

@mchen10
Copy link

mchen10 commented Dec 12, 2024

Hey we're also seeing this. The data actually differs from what's shown in Wikipedia. Any ideas on why/can we get it corrected?

@wooorm
Copy link
Owner

wooorm commented Dec 13, 2024

Then presumably either Wikipedia changed, or there is a bug in the code here. Crawling tons of user based data from Wikipedia is error prone. Solving things not trivial. But it is possible: you could do a PR to solve things here (try running the scripts and if they do not work, fix them). Or on Wikipedia. Or, raise an issue with ISO to get them to open source data. It’s ridiculous that this isn’t open. I am on holiday so don’t have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants