Declare gallery v2 field as optional #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used as a fallback when the API response omits the galleryWithImageBlocks property.
By doing this, Gson won't coerce the missing value to false when the property is omitted in the response, instead leaving it `null`. This allows us to fallback to a reasonable value based on the WP version.
This was referenced May 26, 2023
fluiddot
approved these changes
May 26, 2023
There was a problem hiding this comment.
LGTM 🎊 ! Thanks @mkevins for fixing this 🙇 .
I've tested these changes in combo with wordpress-mobile/WordPress-Android#18519 and confirmed the Gallery block version is picked properly on different scenarios 🎊 :
- WP 5.8.7 + Gutenberg plugin disabled => Gallery v1 ✅
- WP 5.8.7 + Gutenberg plugin 13.6.0 => Gallery v1 ✅
- WP 5.9 + Gutenberg plugin disabled => Gallery v2 (this case is related to Galleries with captioned images no longer function properly WordPress-Android#17712 and Gallery block: Determine
galleryWithImageBlocksprop value based on the WordPress version of the site when value is unknown WordPress/gutenberg#47782) ✅ - WP 5.9 + Gutenberg plugin 13.6.0 => Gallery v2 ✅
NOTE: The latest version of the Gutenberg plugin that supports WP 5.8 is version 13.6.0 (The minimum supported WP version was set to 5.9 in Gutenberg plugin version 13.7).
derekblank
approved these changes
May 29, 2023
|
Thank you both for testing and reviewing these changes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: wordpress-mobile/WordPress-Android#18519
Fixes wordpress-mobile/WordPress-Android#17712
Description
This PR declares the
galleryWithImageBlocksfield to be optional, since it is sometimes omitted from the API response. In that case, this falls back to using the WordPress core version to determine whether v2 gallery support is enabled.