-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg: Update to v1.15.0 #12691
Gutenberg: Update to v1.15.0 #12691
Conversation
Tested on iPhone 8 iOS 12. I have the "Increase Contrast" accessibility setting enabled and I noticed the inserter button has a different border color than fill color: If I disable that setting, it has the same color: Also, I noticed a faint white separation between the border and the fill. This is really not noticeable on screen, but it came up as I was cropping the previous screenshot and zoomed in: |
On iPhone XS iOS 13, it's hard to spot but the toolbar has a left border, which is barely visible on light mode but produces an odd glow effect on dark mode: RichText doesn't show a capitalized keyboard the first time it gets focus:
I found this when inserting a media-text block, uploading an image, then trying to write the text, but it seems more generic to RichText |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some minor things, but it's generally looking good
Thank you @koke for the review!
Yes, we made a trick with borders to make the icon look thicker. Definitely we should use a proper icon to solve this. Will create a ticket to track it. But it's not regression so I'd say it's not a blocker 👍
This also have been noted by @iamthomasbishop before (I believe there should be a ticket somewhere?). Sadly it's true that it's a lot more noticeable in dark mode. Again, not a regression so probably not a blocker. |
I've been hoping to get this removed for a while – related issue here.
Def not a blocker, but important to fix :)
I think this isn't a blocker for this issue, but can we make sure to escalate this to ensure it's fixed asap? |
There's already a PR for this: |
You can trigger an installable build for these changes by visiting CircleCI here. |
af9d1b2
to
8d292a3
Compare
This PR updates Gutenberg to v1.15.0
gutenberg-mobile
PR: wordpress-mobile/gutenberg-mobile#1445To test:
Update release notes:
RELEASE-NOTES.txt
if necessary.