Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Update to v1.15.0 #12691

Merged
merged 13 commits into from
Oct 17, 2019
Merged

Gutenberg: Update to v1.15.0 #12691

merged 13 commits into from
Oct 17, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Oct 14, 2019

This PR updates Gutenberg to v1.15.0
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1445

To test:

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom self-assigned this Oct 14, 2019
@SergioEstevao SergioEstevao added the Gutenberg Editing and display of Gutenberg blocks. label Oct 14, 2019
@SergioEstevao SergioEstevao added this to the 13.5 milestone Oct 14, 2019
@etoledom etoledom marked this pull request as ready for review October 15, 2019 09:37
@koke
Copy link
Member

koke commented Oct 15, 2019

Tested on iPhone 8 iOS 12. I have the "Increase Contrast" accessibility setting enabled and I noticed the inserter button has a different border color than fill color:

IMG_2BE502BAEA9D-1

If I disable that setting, it has the same color:

IMG_C1C4A573C8FC-1

Also, I noticed a faint white separation between the border and the fill. This is really not noticeable on screen, but it came up as I was cropping the previous screenshot and zoomed in:

Screen Shot 2019-10-15 at 15 48 04

@koke
Copy link
Member

koke commented Oct 15, 2019

On iPhone XS iOS 13, it's hard to spot but the toolbar has a left border, which is barely visible on light mode but produces an odd glow effect on dark mode:

inserter-light-dark


RichText doesn't show a capitalized keyboard the first time it gets focus:

  1. Create a new post
  2. Tap on the placeholder text, keyboard should show uppercase letters
  3. Dismiss the keyboard
  4. Tap on the paragraph again, keyboard shows lowercase letters

I found this when inserting a media-text block, uploading an image, then trying to write the text, but it seems more generic to RichText

Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some minor things, but it's generally looking good :shipit:

@etoledom
Copy link
Contributor Author

Thank you @koke for the review!

I have the "Increase Contrast" accessibility setting enabled and I noticed the inserter button has a different border color than fill color:

Yes, we made a trick with borders to make the icon look thicker. Definitely we should use a proper icon to solve this. Will create a ticket to track it.

But it's not regression so I'd say it's not a blocker 👍

it's hard to spot but the toolbar has a left border, which is barely visible on light mode but produces an odd glow effect on dark mode

This also have been noted by @iamthomasbishop before (I believe there should be a ticket somewhere?). Sadly it's true that it's a lot more noticeable in dark mode. Again, not a regression so probably not a blocker.

@etoledom
Copy link
Contributor Author

etoledom commented Oct 17, 2019

I found a couple of issues:

The Hx buttons from the Heading block have a different color in DarkMode.
H_icon_color

This one looks bad: Adding a photo by taking it with the camera, the image gets rotated.
This doesn't seem to be a problem with gutenberg though, since it also happens adding a photo directly to the Media Library.
Image

I wouldn't say any of these are blockers, so ✅ from my side on the release.

@iamthomasbishop
Copy link

@koke

On iPhone XS iOS 13, it's hard to spot but the toolbar has a left border, which is barely visible on light mode but produces an odd glow effect on dark mode:

This also have been noted by @iamthomasbishop before (I believe there should be a ticket somewhere?)

I've been hoping to get this removed for a while – related issue here.


@etoledom 👇

The Hx buttons from the Heading block have a different color in DarkMode.

Def not a blocker, but important to fix :)

Adding a photo by taking it with the camera, the image gets rotated.
This doesn't seem to be a problem with gutenberg though, since it also happens adding a photo directly to the Media Library.

I think this isn't a blocker for this issue, but can we make sure to escalate this to ensure it's fixed asap?

@etoledom
Copy link
Contributor Author

I think this isn't a blocker for this issue, but can we make sure to escalate this to ensure it's fixed asap?

There's already a PR for this:
wordpress-mobile/MediaPicker-iOS#338

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 17, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

@mchowning mchowning force-pushed the gutenberg/release-1.15.0 branch from af9d1b2 to 8d292a3 Compare October 17, 2019 20:13
@mchowning mchowning merged commit efef76c into develop Oct 17, 2019
@mchowning mchowning deleted the gutenberg/release-1.15.0 branch October 17, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants