Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed block] Alignment options #3284

Closed
ceyhun opened this issue Mar 17, 2021 · 1 comment · Fixed by #3787
Closed

[Embed block] Alignment options #3284

ceyhun opened this issue Mar 17, 2021 · 1 comment · Fixed by #3787
Assignees
@fluiddot
Labels
Embed block [Type] Task

Comments

@ceyhun
Copy link
Contributor

ceyhun commented Mar 17, 2021

Description

  • Enable alignment options and implement block styling based on selected option

Screenshot
@ceyhun ceyhun changed the title [Embed block] Change alignment [Embed block] Alignment options Mar 17, 2021
@fluiddot fluiddot self-assigned this Jul 5, 2021
@fluiddot
Copy link
Contributor

fluiddot commented Jul 6, 2021

I verified that the alignment options on the first version work as expected without including any implementation for the native version. However, I wouldn't close the issue because most likely this feature would require to be revisited once we implement the embed preview.

Results

Here we can see the different alignment results with its preview:

Align left (Twitter embed)

Editor Preview

Align center (Tik Tok embed)

Editor Preview

Align right (Tumblr embed)

Editor Preview

Wide width (YouTube embed)

Editor Preview

Full width (Spotify embed)

Editor Preview

@fluiddot fluiddot removed their assignment Jul 13, 2021
@fluiddot fluiddot self-assigned this Jul 21, 2021
This was referenced Jul 30, 2021
Merged
Merged
@fluiddot fluiddot linked a pull request Aug 3, 2021 that will close this issue
[Embed block] Alignment options #3787
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fluiddot fluiddot

Labels
Embed block [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Embed block] Alignment options wordpress-mobile/gutenberg-mobile
2 participants
@ceyhun @fluiddot