Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @-mentions while editing #331

Closed
hypest opened this issue Dec 6, 2018 · 8 comments · Fixed by #2163 or #2424
Closed

Support @-mentions while editing #331

hypest opened this issue Dec 6, 2018 · 8 comments · Fixed by #2163 or #2424
Assignees
Labels
[Pri] High Project: Flow improvements Revise/enhance various editing flows [Status] In Progress [Type] Enhancement Improves a current area of the editor
Milestone

Comments

@hypest
Copy link
Contributor

hypest commented Dec 6, 2018

It would be nice if we could support @-mentions while editing, to add an explicit mention to a site user.

@hypest hypest added the [Type] Enhancement Improves a current area of the editor label Dec 6, 2018
@hypest hypest added this to the Future milestone Dec 6, 2018
@koke
Copy link
Member

koke commented Dec 10, 2018

Just adding that rather than mentions specifically, Gutenberg supports a customizable system of autocompleters, so whenever we implement this we should build on top of that.

@hypest hypest removed this from the Future milestone Nov 21, 2019
@hypest hypest added the Project: Flow improvements Revise/enhance various editing flows label Feb 28, 2020
@designsimply
Copy link
Contributor

This came up in a mobile request from @elibud after it was reported in some feedback that @ mentions were not working in expanded view for comments on WPiOS (now fixed) and we did a full audit of mentions after that. Username mentions are expected to work while composing a post and because this is an important feature when working remotely, can we move this request up in prioritization? @hypest can you help me with that by letting me know what release we can try for to get this added to?

(internal reference: p4a5px-2vE-p2)

@hypest
Copy link
Contributor Author

hypest commented Mar 23, 2020

@SergioEstevao will do a spike on this one to see what are the pieces missing/etc. This feature is probably also going to need some design (headsup @iamthomasbishop).

No specific target version yet @designsimply . We need to uncover more info before being specific there.

@SergioEstevao SergioEstevao self-assigned this Mar 24, 2020
@elibud
Copy link

elibud commented Mar 30, 2020

I'd like to see this one prioritized please.

@hypest
Copy link
Contributor Author

hypest commented Mar 30, 2020

@SergioEstevao is a bit busy at the moment and will be on some rotations the following 2 weeks so, @mchowning will step in next week to pick up this feature.

@mchowning mchowning self-assigned this Apr 7, 2020
@mchowning
Copy link
Contributor

👋 @iamthomasbishop ! Do you have an svg icon to be used for the button?

@iamthomasbishop
Copy link
Contributor

@mchowning Assuming you mean the @ symbol, I don't at the moment but I will create one today.

@iamthomasbishop
Copy link
Contributor

As mentioned in DM, icon was added to the design docs.

@SergioEstevao SergioEstevao modified the milestones: 1.29, 1.30 May 26, 2020
@SergioEstevao SergioEstevao modified the milestones: 1.30, 1.31 Jun 17, 2020
@SergioEstevao SergioEstevao modified the milestones: 1.31, 1.32 Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment