Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hide keyboard button #350

Closed
koke opened this issue Dec 11, 2018 · 9 comments
Closed

Improve hide keyboard button #350

koke opened this issue Dec 11, 2018 · 9 comments
Assignees
Milestone

Comments

@koke
Copy link
Member

koke commented Dec 11, 2018

As part of #55, we have a functional button to hide the keyboard, but it doesn't match the designs:

screen shot 2018-10-17 at 3 55 14 pm

We need to make sure it has the right icon and that it stays on the right side of the toolbar

@koke koke added this to the Beta milestone Dec 11, 2018
@koke koke modified the milestones: Beta, Alpha Dec 18, 2018
@koke
Copy link
Member Author

koke commented Dec 18, 2018

Moving this to the alpha since the current icon is quite confusing. Only the icon is important for the alpha, the rest is nice to have

@marecar3
Copy link
Contributor

Hey @iamthomasbishop, please can you share with us some thoughts about what kind of dash icon we can use here? thanks!

@iamthomasbishop
Copy link
Contributor

I think the easiest path here would be to use Material's icon. However, my preferred solution would be to use the standard Material icon on Android and for iOS use this icon.

Here they are side-by-side (Android left, iOS right):

screen shot 2018-12-18 at 11 18 49 am

@marecar3
Copy link
Contributor

marecar3 commented Dec 18, 2018

Hey @iamthomasbishop , we can't use material icon as it has 24x24 dimension and our view box is 20x20 (which we can't change at this moment)

@koke gave an example

and it gets blurry if resized

screen shot 2018-12-18 at 16 06 58

@iamthomasbishop
Copy link
Contributor

Ah that's right, I had forgotten those are on a 20pt grid. I'm not familiar with the technical considerations for the view box size, but I think we should switch to use a 24pt icon structure asap, considering Gridicons, Material, and probably all other icons used in this context (and across the apps) are set on a 24pt/dp grid. For the time being, I can create a custom 20pt icon to use here, but we should consider moving to 24 sooner than later, even if that means deciding on a new replacement icon for each toolbar item.

@marecar3
Copy link
Contributor

marecar3 commented Dec 18, 2018

I can create a custom 20pt icon to use here

This would be perfect for the alpha. @iamthomasbishop can you share it with me when you have it? Tnx.

@koke is switching to 24x24 Material icons realistic for beta? Tnx.

@koke
Copy link
Member Author

koke commented Dec 18, 2018

I don’t imagine any major technical challenges for that on the beta, so it sounds good. I’m not sure I have a good understanding of all the details involved though

@marecar3
Copy link
Contributor

@iamthomasbishop @koke I have opened the issue for beta : #403

@marecar3 marecar3 self-assigned this Dec 19, 2018
@etoledom etoledom self-assigned this Dec 20, 2018
@koke koke modified the milestones: Alpha, Beta Dec 20, 2018
@iamthomasbishop
Copy link
Contributor

Looping back to this, from looking at the latest alpha, it looks like the toolbar is mostly done, but I'd still like to make sure the keyboard toggle is docked to the right side of the screen – or at very least, appended to the end of the tool list.

@marecar3 marecar3 removed their assignment Jan 17, 2019
@etoledom etoledom removed their assignment Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants