Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus on title when the editor loads #357

Closed
koke opened this issue Dec 12, 2018 · 6 comments
Closed

Focus on title when the editor loads #357

koke opened this issue Dec 12, 2018 · 6 comments

Comments

@koke
Copy link
Member

koke commented Dec 12, 2018

When gutenberg is opened in the apps, make the title focused. On iOS, there is no focus. On Android, the title has focus but the keyboard isn't up until you tap.

I think this was done initially for the previous demo, but it was disabled since it caused some layout issues with the toolbar on iOS

@koke koke added this to the Alpha milestone Dec 12, 2018
@hypest
Copy link
Contributor

hypest commented Dec 12, 2018

On Android, the title has focus but the keyboard isn't up until you tap.

I'm under the impression that that was by design and started before gutenberg-mobile. I'll try to find the relevant info. EDIT: My search didn't surface something. I had this impression that we've been focusing and bringing the keyboard up automatically in the past but, we moved away into just letting the user decide which part of the post (title or content) to focus after entering the post editing screen.

@etoledom
Copy link
Contributor

etoledom commented Dec 17, 2018

[iOS]:
Closed via #373 and wordpress-mobile/WordPress-iOS#10654

@etoledom
Copy link
Contributor

Reopening to get updates on Android side.
cc @hypest

@etoledom etoledom reopened this Dec 17, 2018
@etoledom etoledom removed their assignment Dec 17, 2018
@marecar3 marecar3 self-assigned this Dec 18, 2018
@marecar3
Copy link
Contributor

marecar3 commented Dec 19, 2018

From @koke comment

sounds good. I think we’ll want to standardize that across platforms during the beta, but for now, following Aztec is ok

iOS Aztec -> will focus title when new post or old post is opened
Android Aztec -> won't focus anything when new post or old post is opened

cc: @etoledom @hypest

@marecar3
Copy link
Contributor

Final conslusion from @hypest's chat message :

@iamthomasbishop’s feedback is actually the latest one as he’s already taking into account Eli’s feedback:
• (Previously mentioned by @elibud ) Title should be focused right away when new post is created. (iOS)
• when an existing post is loaded, we should assume no block focus and keyboard should be hidden (iOS, Android)

to me that reads: focus the title on enter but only for new posts

@etoledom

@mzorz
Copy link
Contributor

mzorz commented Dec 20, 2018

Closing via #8826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants