-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Gutenberg-Mobile Target SDK to 34 #6533
Comments
Hey @notandyvee 👋 , the process to update the target SDK will be similar to the one documented in #5556. The main difference is that in this case, we'll need to update fewer third-party libraries. I took the liberty to update the task list in the issue's description. Thanks 🙇 ! |
Thank you for confirming @fluiddot . I can use that as a checklist for understanding the process further. 🙏🏻 |
@notandyvee I couldn't find a branch in WordPress-Android related to the target SDK upgrade. I'd like to test the React Native patch to address the error |
@notandyvee I have prepared the different PRs needed for this tracking issue. The only one remaining is updating the Aztec version, however, we'd first need to tackle wordpress-mobile/AztecEditor-Android#1072. Let me know if you are planning to work on it, in the meantime, I'm going to pause my work on this issue. Thanks 🙇 !
|
Firstly, thank you @fluiddot for working on this so quickly. Extremely helpful 🙏🏻 .
Known issue. I have a fix locally. It's a security issue required by the target sdk update. Nothing to do with gutenberg. I'll put up a PR later today so we can use it for testing and for visibility.
I can attempt to tackle that. How are gutenberg and aztec related? |
Gutenberg Mobile uses Aztec for rendering rich text content. Most of the text rendered within the editor uses it. |
Apologies for the delay @fluiddot . The PR with the updates to avoid image crashing are here: wordpress-mobile/WordPress-Android#19979. I will tackle Aztec next. |
All tasks have been completed 🚀 |
Task list
java.lang.RuntimeException: Requested enabled DevSupportManager, but BridgeDevSupportManager class was not found or could not be created
bypatching React Native with this fixupgrading React Native to version 0.71.13+ ([RNMobile] Upgrade React Native to version 0.71.15 WordPress/gutenberg#57667)targetSdk
to 34 on Gutenberg ([Mobile] Upgrade target sdk version to Android API 34 WordPress/gutenberg#61727)targetSdk
to 34 onAztecEditor-Android
(Upgrade AztecEditor-Android Target SDK to 34 AztecEditor-Android#1072)compileSdk
andtargetSdk
to 34 in react-native-libraries-publisher (Upgrade default target sdk version to Android API 34 (Android 14) react-native-libraries-publisher#31)compileSdk
andtargetSdk
to 34 inreact-native-slider
(Upgrade compile and target sdk version to Android API 34 react-native-slider#15)compileSdk
andtargetSdk
to 34 inreact-native-video
(Upgrade compile and target sdk version to Android API 34 react-native-video#23)Note: I'm not certain as to the full process involved in doing that here. Will compare with the Android 13 issue - #5556
The text was updated successfully, but these errors were encountered: