Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gutenberg-Mobile Target SDK to 34 #6533

Closed
10 tasks done
notandyvee opened this issue Jan 10, 2024 · 8 comments · Fixed by #6870
Closed
10 tasks done

Upgrade Gutenberg-Mobile Target SDK to 34 #6533

notandyvee opened this issue Jan 10, 2024 · 8 comments · Fixed by #6870
Assignees
Labels
Android 14 dependencies Pull requests that update a dependency file [Type] Task

Comments

@notandyvee
Copy link

notandyvee commented Jan 10, 2024

Task list

Note: I'm not certain as to the full process involved in doing that here. Will compare with the Android 13 issue - #5556

@fluiddot
Copy link
Contributor

Hey @notandyvee 👋 , the process to update the target SDK will be similar to the one documented in #5556. The main difference is that in this case, we'll need to update fewer third-party libraries. I took the liberty to update the task list in the issue's description. Thanks 🙇 !

@fluiddot fluiddot added [Type] Task dependencies Pull requests that update a dependency file labels Jan 11, 2024
@notandyvee
Copy link
Author

Thank you for confirming @fluiddot . I can use that as a checklist for understanding the process further. 🙏🏻

@fluiddot
Copy link
Contributor

@notandyvee I couldn't find a branch in WordPress-Android related to the target SDK upgrade. I'd like to test the React Native patch to address the error java.lang.RuntimeException: Requested enabled DevSupportManager, but BridgeDevSupportManager class was not found or could not be created. Let me know if you could share the branch, or if it's not created yet, ping me when it's ready. Thanks 🙇 !

@fluiddot
Copy link
Contributor

@notandyvee I have prepared the different PRs needed for this tracking issue. The only one remaining is updating the Aztec version, however, we'd first need to tackle wordpress-mobile/AztecEditor-Android#1072. Let me know if you are planning to work on it, in the meantime, I'm going to pause my work on this issue. Thanks 🙇 !

⚠️ I've tested WP-Android app after updating targetSdk in an emulator with Android 14, and noticed that the app crashes when uploading media. I thought this was related to the editor, but it can also be reproduced when uploading from the Media screen. Sharing this here so you are aware of this issue when working in wordpress-mobile/WordPress-Android#19917.

@notandyvee
Copy link
Author

Firstly, thank you @fluiddot for working on this so quickly. Extremely helpful 🙏🏻 .

I've tested WP-Android app after updating targetSdk in an emulator with Android 14, and noticed that the app crashes when uploading media.

Known issue. I have a fix locally. It's a security issue required by the target sdk update. Nothing to do with gutenberg. I'll put up a PR later today so we can use it for testing and for visibility.

The only one remaining is updating the Aztec version, however, we'd first need to tackle wordpress-mobile/AztecEditor-Android#1072.

I can attempt to tackle that. How are gutenberg and aztec related?

@fluiddot
Copy link
Contributor

The only one remaining is updating the Aztec version, however, we'd first need to tackle wordpress-mobile/AztecEditor-Android#1072.

I can attempt to tackle that. How are gutenberg and aztec related?

Gutenberg Mobile uses Aztec for rendering rich text content. Most of the text rendered within the editor uses it.

@notandyvee
Copy link
Author

notandyvee commented Jan 18, 2024

Apologies for the delay @fluiddot . The PR with the updates to avoid image crashing are here: wordpress-mobile/WordPress-Android#19979. I will tackle Aztec next.

@geriux
Copy link
Contributor

geriux commented May 20, 2024

All tasks have been completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 14 dependencies Pull requests that update a dependency file [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants