Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert BlockManager into BlockList #958

Closed
10 tasks done
koke opened this issue May 6, 2019 · 1 comment
Closed
10 tasks done

Convert BlockManager into BlockList #958

koke opened this issue May 6, 2019 · 1 comment

Comments

@koke
Copy link
Member

koke commented May 6, 2019

In previous efforts we tried to port the BlockManager and related components from the Gutenberg mobile repository to the Gutenberg repository, to pave the way for inner blocks on RN mobile. However that prove to be unsuccessful as the PR was getting too big to review at once.

To give more context, BlockManager is the equivalent of BlockList and it depends on many components that still lives in the gutenberg-mobile repo.
The goal here will be to make that port so that we can ultimately have BlockList be reused from the gutenberg repository in components such as InnerBlock.

This issue will serve as a reference for this task and will help monitor the progress on the different PRs.

Most of the work was already done in #789, but we're going to break it down now into smaller pieces to make it easier to review.

Suggested plan:

Originally posted in #789 (comment)

cc @koke @hypest @daniloercoli @gziolo

@koke
Copy link
Member Author

koke commented May 16, 2019

Removing my assignment for now. @Tug will take over this, and I'll help where I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants