-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert BlockManager into BlockList #958
Comments
This was referenced May 6, 2019
Removing my assignment for now. @Tug will take over this, and I'll help where I can. |
8 tasks
5 tasks
This was referenced Jun 6, 2019
This was referenced Jun 14, 2019
Merged
This was referenced Jun 19, 2019
Merged
This was referenced Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In previous efforts we tried to port the BlockManager and related components from the Gutenberg mobile repository to the Gutenberg repository, to pave the way for inner blocks on RN mobile. However that prove to be unsuccessful as the PR was getting too big to review at once.
To give more context,
BlockManager
is the equivalent ofBlockList
and it depends on many components that still lives in the gutenberg-mobile repo.The goal here will be to make that port so that we can ultimately have BlockList be reused from the gutenberg repository in components such as
InnerBlock
.This issue will serve as a reference for this task and will help monitor the progress on the different PRs.
Most of the work was already done in #789, but we're going to break it down now into smaller pieces to make it easier to review.
Suggested plan:
BottomSheet
andPicker
to@wordpress/components
make them available from outside theblock-editor
package (GB PR#15750 and GB-Mobile PR#1008)KeyboardAvoidingView
,KeyboardAwareFlatList
andReadableContentView
to gutenberg so we can reuse those from there (GB PR#15913 and GB-Mobile PR#1048)Inserter
ported fromBlockPicker
(GB PR#16114 and GB-Mobile PR#1122)BlockMobileToolbar
ported fromInlineToolbar
(GB PR#16177 and GB-Mobile PR#1133)BlockToolbar
ported fromBlockToolbar
(GB PR#16213 and GB-Mobile PR#1149)BlockListBlock
ported fromBlockHolder
(GB PR#16223 and GB-Mobile PR#1155)HTMLTextInput
ported fromHTMLTextInput
(GB PR#16226 and GB-Mobile PR#1162)BlockList
ported fromBlockManager
(GB PR#16239 and GB-Mobile PR#1169)MainScreen
,AppContainer
andApp
to gutenberg (GB PR#16260 and GB-Mobile PR#1171)InnerBlock
by adding support forMediaText
(GB PR#16305)Originally posted in #789 (comment)
cc @koke @hypest @daniloercoli @gziolo
The text was updated successfully, but these errors were encountered: