Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isAppender functionality to MediaPlaceholder #1327

Merged
merged 25 commits into from
Sep 30, 2019

Conversation

lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Aug 26, 2019

Fixes #1299
This PR is adding isAppender functionality to mobile MediaPlaceholder component.

Related gutenberg PR - WordPress/gutenberg#17195

See issue #1299

@lukewalczak lukewalczak marked this pull request as ready for review August 27, 2019 10:26
@pinarol pinarol requested review from mkevins and koke August 30, 2019 12:26
@pinarol pinarol added Media [Type] Enhancement Improves a current area of the editor labels Sep 24, 2019
@pinarol pinarol added this to the 1.13 milestone Sep 24, 2019
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukewalczak lukewalczak force-pushed the callstack/rnmobile-is-appender branch from 800b38d to d91f56c Compare September 26, 2019 10:10
@lukewalczak lukewalczak force-pushed the callstack/rnmobile-is-appender branch from 8fff319 to a596e6f Compare September 27, 2019 14:08
@lukewalczak lukewalczak merged commit 57459f9 into develop Sep 30, 2019
@lukewalczak lukewalczak deleted the callstack/rnmobile-is-appender branch September 30, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross Platform MediaPlaceholder component
2 participants