Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Adjust vertical margins in InnerBlock #1838

Merged
merged 12 commits into from
Feb 4, 2020
Merged

Fix: Adjust vertical margins in InnerBlock #1838

merged 12 commits into from
Feb 4, 2020

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented Jan 30, 2020 •
edited
Loading

Fixes #1789

PR provides additional login to adjust vertical margins when navigate through InnerBlock hierarchy.

Please also refer to:
Related gutenberg PR
Related gutenberg-mobile issue

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jbinda jbinda requested review from koke and pinarol January 30, 2020 10:11
@jbinda jbinda self-assigned this Jan 30, 2020
@jbinda jbinda mentioned this pull request Jan 30, 2020
Merged
6 tasks
@pinarol pinarol merged commit 79c17ca into develop Feb 4, 2020
@pinarol pinarol deleted the callstack/fix-innerblocks-vertical-margin branch February 4, 2020 09:46
This was referenced Feb 17, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koke koke koke approved these changes

@pinarol pinarol Awaiting requested review from pinarol

Assignees

@jbinda jbinda

Labels
bugfix InnerBlocks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust Navigation Down bordering logic to avoid vertical margins multiplication when nesting
4 participants
@jbinda @koke @pinarol @lukewalczak