Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force re-upload of images for equations/ tables #44

Closed
Daniel-Mietchen opened this issue Oct 3, 2014 · 5 comments
Closed

Force re-upload of images for equations/ tables #44

Daniel-Mietchen opened this issue Oct 3, 2014 · 5 comments
Assignees

Comments

@Daniel-Mietchen
Copy link
Member

Once the upload of images for equations/ tables to Wikisource works, we will need another checkbox in the web form, with the option to force re-upload of these, perhaps separately for tables and figures.

@notconfusing
Copy link
Member

at the moment, im treating all images as one, regardless if they go to commons or wikisource. however, we can handle them separately. right now if you check reupload images then all the images will be attempted to reupload.

@notconfusing
Copy link
Member

done in d8159c8

@Daniel-Mietchen
Copy link
Member Author

For formulas/ equations formatted like

<disp-formula>
    <graphic xlink:href="pcbi.1000667.e015"/>
</disp-formula>

the wikicode should always specify "frameless|left", and a line break should be added after the embedded image:

[[File:A-Primer-on-Metagenomics-pcbi.1000667.e015.jpg|frameless|left]]<br/>

@wrought
Copy link
Member

wrought commented Oct 21, 2014

Might be a fringe case when using the left alignment of formula inside of a table, as formulae are permitted by JATS.

Patch made in JATS-to-mediawiki library with commit http://github.com/wpoa/JATS-to-mediawiki/commit/4e1fd7ac6ca7b2eea1b1e9879e896639dbe5308f

@wrought wrought closed this as completed Oct 21, 2014
@wrought wrought reopened this Oct 21, 2014
@wrought
Copy link
Member

wrought commented Oct 21, 2014

After trying newlines (&c#A;, <br />) and even a css clear (<div style="clear: both;"></div>), turns out the best path is to add a |none value to the [[File:...]] tag, which wraps the file in a div displaying at full size and including a line break via the floatnone class.

See it in action here: https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/A_Primer_on_Metagenomics

@wrought wrought closed this as completed Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants