Add scaleFactor to CLI | Add .cancel function #20
Conversation
index.d.ts
Outdated
| /** | ||
| Scale factor to use | ||
| Useful when recording retina screens, or for resizing the recorded video | ||
| */ |
There was a problem hiding this comment.
Incorrect indentation.
There was a problem hiding this comment.
Is it worth adding prettier to the project? Would avoid these sort of issues.
There was a problem hiding this comment.
Nah. prettier does indeed make things more consistent, but IMHO also less readable and ugly.
index.d.ts
Outdated
| /** | ||
| Cancels a recording, if it was started | ||
| */ | ||
| cancelRecording: () => void; |
There was a problem hiding this comment.
I just noticed that we have been very inconsistent with naming. I think this should be cancel(). I'll fix the other methods when this is merged.
|
You need to update the readme too. |
|
For next time, the |
dac09
changed the title
|
|
||
| recorderTimeout = undefined |
There was a problem hiding this comment.
| recorderTimeout = undefined | |
| _recorderTimeout = undefined |
| @@ -101,6 +108,11 @@ declare namespace aperture { | |||
| Returns a `Promise` for the path to the screen recording file. | |||
| */ | |||
| stopRecording: () => Promise<string>; | |||
|
|
|||
| /** | |||
| Cancels a recording, if it was started | |||
There was a problem hiding this comment.
| Cancels a recording, if it was started | |
| Cancels a recording if it was running. |
|
Readme and index.d.ts should be fully in sync. |
| Scale factor to use | ||
| The actual height and width of the capture will be multiplied by this number to create the height and width of the output. | ||
| @default 1 |
There was a problem hiding this comment.
| Scale factor to use | |
| The actual height and width of the capture will be multiplied by this number to create the height and width of the output. | |
| @default 1 | |
| The scale factor to use. | |
| The actual height and width of the capture will be multiplied by this number to create the height and width of the output. | |
| @default 1 |
What does it do?
cancelfunction to stop and discard the recordingFixes #18
Please note I haven't had a chance to test this out yet on this version, but I am using something similar in my older fork