Linux Support (again) #32

fearphage · 2017-03-17T04:48:44Z

This is the fixes (and some) of the PR #7. I couldn't figure out how to continue progress on that branch/PR.

Let me know if everything still works.

Question: Why don't we/you use ffmpeg on all platforms? It seems like it would greatly simplify the code and it would add support for MacOS older than 10.10.

sindresorhus · 2017-03-17T06:36:10Z

Why don't we/you use ffmpeg on all platforms?

https://github.com/wulkano/aperture#why

sindresorhus · 2017-03-17T06:40:46Z

Also note my comment in #7: #7 (comment)

sindresorhus · 2017-03-17T06:36:56Z

index.js

+    if (process.platform === 'darwin') {
+      return execa.stdout(path.join(__dirname, 'swift/main'), ['list-audio-devices']).then(JSON.parse);
+    } else if (process.platform === 'linux') {
+      return execa.stdout('sh', ['-c', "arecord -l | awk 'match(\$0, /card ([0-9]): ([^,]+),/, result) { print result[1] \":\" result[2] }'"]);


We should use JS for as much as possible. No awk.

sindresorhus · 2017-03-17T06:38:28Z

package.json

-    "build": "cd swift && xcodebuild -derivedDataPath $(mktemp -d) -scheme aperture",
-    "prepublish": "npm run build"
+    "build-macos": "cd swift && xcodebuild -derivedDataPath $(mktemp -d) -scheme aperture",
+    "postinstall": "[ \"$(uname)\" = \"Darwin\" ] && npm run build-macos",


This one should be removed.

sindresorhus · 2017-03-17T06:42:03Z

index.js

@@ -9,11 +9,17 @@ const debuglog = util.debuglog('aperture');

 class Aperture {
  constructor() {
-    macosVersion.assertGreaterThanOrEqualTo('10.10');
+    if (process.platform === 'darwin') {


Create top level constants IS_MACOS and IS_LINUX to simplify all these if else statements.

sindresorhus · 2017-03-17T06:44:53Z

Let me know if everything still works.

You can do that by putting the following in index.js:

module.exports().startRecording().then(console.log).catch(console.error);

fearphage · 2017-03-17T13:47:13Z

You can do that by putting the following

I'm sure it works for me. I just have zero macs on which to confirm the functionality.

I addressed the code review concerns and added the mouse cursor toggle.

fearphage · 2017-03-17T14:13:46Z

Not sure what changed between last night and today, but I was getting strings back from the stderr stream and now I'm getting buffers. Weird.

fearphage · 2017-03-24T19:27:13Z

@sindresorhus Anything else?

sindresorhus · 2017-05-06T07:06:50Z

index.js

+          args.push('-i', ':0');
+        }
+
+        args.push('-framerate', fps, '-draw_mouse', +(showCursor === true), this.tmpPath);


String(showCursor === true)

Did you verify this works? Based on the documentation, draw_mouse expects a binary value. That's why I'm coercing the boolean to an int.

sindresorhus · 2017-05-06T07:14:13Z

Setting showCursor: false doesn't seem to work. I still get the cursor in the recording.

By default it captures only part of the screen, while it should capture the whole screen. Setting the cropArea option does nothing.

.getAudioSources() return duplicate audio sources for me:

[ '0:I82801BAICH2 [Intel 82801BA-ICH2]',
  '0:I82801BAICH2 [Intel 82801BA-ICH2]' ]

It also needs to be in the format:

[ { id: 'AppleHDAEngineInput:1B,0,1,0:1',
    name: 'Built-in Microphone' } ]

ffmpeg version 3.0.7-0ubuntu0.16.10.1

fearphage · 2017-05-07T12:53:32Z

Setting showCursor: false doesn't seem to work

Confirmed.

By default it captures only part of the screen, while it should capture the whole screen

I'll look into it.

.getAudioSources() return duplicate audio sources for me

Cannot reproduce locally.

It also needs to be in the format

From your sample output, is that id [name]?

ffmpeg version 3.0.7-0ubuntu0.16.10.1

Same here.

sindresorhus · 2017-05-07T13:53:12Z

index.js

+    if (IS_MACOS) {
+      return execa.stdout(path.join(__dirname, 'swift/main'), ['list-audio-devices']).then(JSON.parse);
+    } else if (IS_LINUX) {
+      return execa.stdout('arecord', ['-l']).then(


-l => --list-devices

sindresorhus · 2017-05-07T13:53:46Z

From your sample output, is that id [name]?

$ arecord --list-devices
**** List of CAPTURE Hardware Devices ****
card 0: I82801BAICH2 [Intel 82801BA-ICH2], device 0: Intel ICH [Intel 82801BA-ICH2]
  Subdevices: 1/1
  Subdevice #0: subdevice #0
card 0: I82801BAICH2 [Intel 82801BA-ICH2], device 1: Intel ICH - MIC ADC [Intel 82801BA-ICH2 - MIC ADC]
  Subdevices: 1/1
  Subdevice #0: subdevice #0

sindresorhus · 2017-05-07T14:06:21Z

It seems if you specify default to ffmpeg, it will use the default device. According to the web it's sometimes hard to determine this yourself, so maybe we should add in a Default Microphone entry, that just supplies -i default to ffmpeg?

misterhat and others added 4 commits December 4, 2016 10:57

linux support

fdfc522

cleanup based on code review comments

d9b84c3

Merge branch 'master' of https://github.com/wulkano/aperture into gnu

dc4ad0b

updates to linux functionality

d6cace1

sindresorhus suggested changes Mar 17, 2017

View reviewed changes

addressed code review comments

b2ea650

video_size needs to come before input device

3e58b2b

sindresorhus suggested changes May 6, 2017

View reviewed changes

sindresorhus reviewed May 7, 2017

View reviewed changes

sindresorhus mentioned this pull request Jun 2, 2017

Linux support #7

Closed

albinekb mentioned this pull request Jun 9, 2017

Windows + Linux support [wip] #37

Closed

2 tasks

skllcrn mentioned this pull request Jul 20, 2017

click is no use in linux/win7 wulkano/Kap#211

Closed

sindresorhus closed this Oct 28, 2017

skllcrn mentioned this pull request May 12, 2018

Linux Support wulkano/Kap#31

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linux Support (again) #32

Linux Support (again) #32

fearphage commented Mar 17, 2017

sindresorhus commented Mar 17, 2017

sindresorhus commented Mar 17, 2017

sindresorhus Mar 17, 2017

sindresorhus Mar 17, 2017

sindresorhus Mar 17, 2017

sindresorhus commented Mar 17, 2017

fearphage commented Mar 17, 2017 •

edited

Loading

fearphage commented Mar 17, 2017

fearphage commented Mar 24, 2017

sindresorhus May 6, 2017

fearphage May 7, 2017

sindresorhus commented May 6, 2017 •

edited

Loading

fearphage commented May 7, 2017

sindresorhus May 7, 2017

sindresorhus commented May 7, 2017

sindresorhus commented May 7, 2017

Linux Support (again) #32

Linux Support (again) #32

Conversation

fearphage commented Mar 17, 2017

sindresorhus commented Mar 17, 2017

sindresorhus commented Mar 17, 2017

sindresorhus Mar 17, 2017

Choose a reason for hiding this comment

sindresorhus Mar 17, 2017

Choose a reason for hiding this comment

sindresorhus Mar 17, 2017

Choose a reason for hiding this comment

sindresorhus commented Mar 17, 2017

fearphage commented Mar 17, 2017 • edited Loading

fearphage commented Mar 17, 2017

fearphage commented Mar 24, 2017

sindresorhus May 6, 2017

Choose a reason for hiding this comment

fearphage May 7, 2017

Choose a reason for hiding this comment

sindresorhus commented May 6, 2017 • edited Loading

fearphage commented May 7, 2017

sindresorhus May 7, 2017

Choose a reason for hiding this comment

sindresorhus commented May 7, 2017

sindresorhus commented May 7, 2017

fearphage commented Mar 17, 2017 •

edited

Loading

sindresorhus commented May 6, 2017 •

edited

Loading