Initial Windows support #38

albinekb · 2017-06-10T00:39:35Z

#37 without linux support

todo

Audio/audiosources
http://zornsoftware.codenature.info/blog/record-screen-audio-with-ffmpeg.html
Split startRecording functions per OS
Figure out how to get ffmpeg (Should we ship the ffmpeg binary (.exe)?)

No, that's too heavy and outside the scope of this plugin. We can add a ffmpegBinary option instead.

albinekb · 2017-06-10T01:04:43Z

@sindresorhus .mp4 was working, but windows media player can't play it 😄 tested with vlc and it works.

sindresorhus · 2017-06-10T10:09:28Z

README.md

@@ -11,13 +11,16 @@
 $ npm install aperture
 ```

-*Requires macOS 10.10 or later.*
+requires: *macOS: 10.10 or later.* | *Windows: ffmpeg*


Should be:

*Requires minimum macOS 10.10 or Windows 7.*

sindresorhus · 2017-06-10T10:09:41Z

README.md



 ## Usage

 ```js
-const aperture = require('aperture')();
+const aperture = require('aperture')({
+  // ffmpegBinary is *required* on Windows


This comment is moot. It's already explained in the docs section.

sindresorhus · 2017-06-10T10:09:59Z

README.md

+##### ffmpegBinary
+
+Type: `string`<br>
+**Required on windows**


windows => Windows

sindresorhus · 2017-06-10T10:11:33Z

index.js

+          ffmpegArgs.push(
+            '-video_size', `${cropArea.width}x${cropArea.height}`,
+            '-f', 'gdigrab',
+            '-i', 'desktop',


The above two arguments can be in the initial array as they appear the same in both conditions.

sindresorhus · 2017-06-10T10:13:05Z

README.md

@@ -1,6 +1,6 @@
 <p>
  <h1 align="center">Aperture</h1>
-  <h4 align="center">Record the screen on macOS</h4>
+  <h4 align="center">Record the screen on macOS & Windows</h4>


You need to update the package.json description too.

albinekb · 2017-06-10T11:27:19Z

Since getAudioSources is outside the class now, how do you want to handle the ffmpegBinary there?

albinekb · 2017-08-31T13:17:00Z

Is there any interest in finishing this? I don't use Windows and never will use this lib on windows, but if there are people that want this I could pick it up and finish it. Thoughts?

sindresorhus · 2017-08-31T13:28:46Z

Not really. I only care about the macOS part. I just reviewed this to be nice.

timothyis · 2017-08-31T13:30:17Z

For now, I don't think we can maintain this without a contributor that has windows. I'll be building a PC at some point this year and then I can maintain it, but for now I don't think we can support it properly. 😢

EDIT: There are people who want this (see our most popular Kap issue) but no one interested in maintaining it. It has to go hand-in-hand.

albinekb · 2017-08-31T14:12:17Z

I just did this to be nice too 😄 But as I use macOS as my main OS, I can't really maintain it.

Should I let this PR be open, and wait for someone to come along (windows maintainer) or close it?

Edit: do you want to find a windows maintainer for this? Should we look over in the kap issue maybe if someone is willing to take this?

sindresorhus · 2017-08-31T15:42:38Z

I'll close this. @albinekb Can you open an issue instead here about adding Windows support? And link to this PR as a starting point.

bdbch · 2018-02-01T12:27:21Z

I use Windows as my main OS besides Arch Linux and could try to pick this up if you guys want me to. (And extend it further with Linux later)

skllcrn · 2018-02-01T12:32:34Z

At this point we won't be expanding the scope of Kap, however, if there was a high quality unofficial fork with support for another OS I'd argue that we should link to that. The reasoning being that maintaining this and any comparable open-source project is a lot of work, and the interest for most stops at the idea of doing it. Additionally, the insight we have tells us that Windows and Linux support will require more work with less people benefitting from it.

levrik · 2018-05-12T15:27:46Z

@skllcrn

with less people benefitting from it.
is purely wrong. I couldn't find a good free screen recording app for Windows. At the moment I use ShareX which works fine but it's a UI nightmare.
At work I use Kap on macOS. Love it and would really like to see it coming to Windows.

skllcrn · 2018-05-12T15:47:31Z

It's always great to hear from people that would like Kap on Windows. We'd love to see someone fork Kap and port it to Windows @levrik! To show your interest your can leave a 👍 on #46 and wulkano/Kap#456.

shawwn · 2018-05-12T15:51:26Z

+1 for Windows support @skllcrn @albinekb. Gamedevs would thank you.

Right now your options for free recording on Windows are Windows Game Recorder (built in) or Streamlams / OBS. Both are less than ideal for recording promo videos and product walkthroughs.

skllcrn · 2018-05-12T16:00:48Z

Thanks for your comment @shawwn, but please refrain from posting "+1" and use 👍 on the related issues instead. When you do that we can sort issues based on reactions, making your voice heard and helping us prioritise. Remember that we work on a lot of projects, some of us in the tens and hundreds, and every single +1 is a notification/activity log item that just causes noise.

To show your interest your can leave a 👍 on #46 and wulkano/Kap#456.

albinekb added 2 commits June 10, 2017 02:38

Initial windows support

21b924e

Record directly to mp4

f45e9a5

albinekb mentioned this pull request Jun 10, 2017

Windows + Linux support [wip] #37

Closed

2 tasks

albinekb added 4 commits June 10, 2017 03:07

Cleanup setEncoding

0127605

Add ffmpegBinary option

0522488

Update readme

01ef2e1

Use ffmpegBinary

9642898

sindresorhus suggested changes Jun 10, 2017

View reviewed changes

sindresorhus reviewed Jun 10, 2017

View reviewed changes

sindresorhus changed the title ~~Initial windows support~~ Initial Windows support Jun 10, 2017

albinekb added 4 commits June 10, 2017 13:08

Readme fixes

20701b6

Update package.json description

0019a0f

Combine ffmpeg args

2c9ff68

Merge

518f0df

Merge remote-tracking branch 'upstream/master' into windows-only

a9af7bc

sindresorhus closed this Aug 31, 2017

albinekb mentioned this pull request Aug 31, 2017

Windows support #46

Closed

skllcrn mentioned this pull request May 12, 2018

Windows support: New Windows 10 Screen Recording APIs wulkano/Kap#456

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial Windows support #38

Initial Windows support #38

albinekb commented Jun 10, 2017 •

edited

Loading

albinekb commented Jun 10, 2017

sindresorhus Jun 10, 2017

sindresorhus Jun 10, 2017

sindresorhus Jun 10, 2017

sindresorhus Jun 10, 2017

sindresorhus Jun 10, 2017

albinekb commented Jun 10, 2017

albinekb commented Aug 31, 2017

sindresorhus commented Aug 31, 2017

timothyis commented Aug 31, 2017 •

edited

Loading

albinekb commented Aug 31, 2017 •

edited

Loading

sindresorhus commented Aug 31, 2017 •

edited

Loading

bdbch commented Feb 1, 2018

skllcrn commented Feb 1, 2018 •

edited

Loading

levrik commented May 12, 2018

skllcrn commented May 12, 2018 •

edited

Loading

shawwn commented May 12, 2018

skllcrn commented May 12, 2018

Initial Windows support #38

Initial Windows support #38

Conversation

albinekb commented Jun 10, 2017 • edited Loading

todo

albinekb commented Jun 10, 2017

sindresorhus Jun 10, 2017

Choose a reason for hiding this comment

sindresorhus Jun 10, 2017

Choose a reason for hiding this comment

sindresorhus Jun 10, 2017

Choose a reason for hiding this comment

sindresorhus Jun 10, 2017

Choose a reason for hiding this comment

sindresorhus Jun 10, 2017

Choose a reason for hiding this comment

albinekb commented Jun 10, 2017

albinekb commented Aug 31, 2017

sindresorhus commented Aug 31, 2017

timothyis commented Aug 31, 2017 • edited Loading

albinekb commented Aug 31, 2017 • edited Loading

sindresorhus commented Aug 31, 2017 • edited Loading

bdbch commented Feb 1, 2018

skllcrn commented Feb 1, 2018 • edited Loading

levrik commented May 12, 2018

skllcrn commented May 12, 2018 • edited Loading

shawwn commented May 12, 2018

skllcrn commented May 12, 2018

albinekb commented Jun 10, 2017 •

edited

Loading

timothyis commented Aug 31, 2017 •

edited

Loading

albinekb commented Aug 31, 2017 •

edited

Loading

sindresorhus commented Aug 31, 2017 •

edited

Loading

skllcrn commented Feb 1, 2018 •

edited

Loading

skllcrn commented May 12, 2018 •

edited

Loading