Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for async and defer for r:include_javascript #33

Closed
adamjohnson opened this issue Jul 9, 2015 · 1 comment
Closed

Add support for async and defer for r:include_javascript #33

adamjohnson opened this issue Jul 9, 2015 · 1 comment
Assignees
@zeroedin
Labels
enhancement

Comments

@adamjohnson
Copy link
Contributor

Nathan added support for asnyc and defer in https://github.com/wvuweb/cleanslate/commit/c61e65b49bb57938153e56af2db0cadb41538062.

Docs on CleanSlate site:

http://cleanslatecms.wvu.edu/how-to/theme-development/tag-index/r-include-javascript

Example code:

<r:include_javascript async="false" defer="false" name="file-1.min, file2" />
@adamjohnson
Copy link
Contributor Author

c13ec16, f670767, 6d1a661, and 361f553 are related to this issue.

Thanks for the help @zeroedin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroedin zeroedin

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeroedin @adamjohnson