Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared themes with different name vs repo names are busted #41

Closed
adamjohnson opened this issue Jan 13, 2016 · 2 comments
Closed

Shared themes with different name vs repo names are busted #41

adamjohnson opened this issue Jan 13, 2016 · 2 comments
Assignees
Labels

Comments

@adamjohnson
Copy link
Contributor

Steps to reproduce the issue

  1. Clone the Adventure WV Repo and the Adventure WV Orientation repo from Stash.
  2. Create a partial named _hello-world.html in cleanslate_themes/student-life-adventure-wv/views/shared.
  3. Add an <h1> inside the file with Hello World as it's content.
  4. Start hammer.
  5. Open the Adventure WV Orientation theme in your text editor.
  6. Open frontpage.html. Paste <r:partial name="shared/hello-world" theme="Student Life: Adventure WV" />.
  7. Open the Mock Data file and add this under the shared themes key:
  "Student Life: Adventure WV":
    "shared/hello-world": "student-life-adventure-wv"

View http://localhost:2000/student-life-adventure-wv-orientation/views/frontpage.html in your browser.

Results

Hammer cannot find the shared partial and throws an error.

Expected results

Hammer should find the shared partial and print its contents.

I suspect this error stems from having fancy characters in the theme name. Eg: Student Life: Adventure WV.

@adamjohnson
Copy link
Contributor Author

#22 is related to this.

@zeroedin
Copy link
Contributor

Link in commit message didn't work correctly should link to: d78a471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants