Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty container element accessibility issue in Photo Essay photo set component #87

Open
rebecca-patton opened this issue Sep 11, 2023 · 1 comment
Open

Empty container element accessibility issue in Photo Essay photo set component #87

rebecca-patton opened this issue Sep 11, 2023 · 1 comment
Assignees
@adamjohnson @adamglenn
Labels
bug Something isn't working

Comments

@rebecca-patton
Copy link
Contributor

Steps to reproduce the issue

  1. Create a page with the Photo Essay Template and add a Photo Set containing photos to a slot
  2. Open the page in your browser and run the SiteImprove extension on the page
  3. Example page: Photo essay test

Results

There is a 'Container element is empty' accessibility error for each photo set.

How to fix

Remove/move the div between the ul tag and the li tags?
@adamjohnson
Copy link
Contributor

This is the line of code that is creating this error:

div-in-ul

Moving the classes from the <div> up to the <ul> will solve the accessibility issue. In my limited testing, the layout remains the same (but more testing is warranted).

@adamjohnson adamjohnson added the bug Something isn't working label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamjohnson adamjohnson

@adamglenn adamglenn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adamjohnson @adamglenn @rebecca-patton