Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet rpt does not work #42

Closed
edvinasjurele opened this issue Mar 24, 2018 · 4 comments
Closed

Snippet rpt does not work #42

edvinasjurele opened this issue Mar 24, 2018 · 4 comments

Comments

@edvinasjurele
Copy link

edvinasjurele commented Mar 24, 2018

It seems rpt snippet does not work for me. Wondering whether it is an issue of my configuration or clash of some other existing configurations.

To reproduce:
image

Anyone else facing this issue?

Other snippet works just fine.

Versions:

  • VSCode v1.21.1
  • Snippets plugin v2.0.0
@FoxShaunR
Copy link

I'm having the same issue.

Versions:

  • VSCode 1.22.0 (1.22.0)
  • Same version of the snippets plugin

@xabikos
Copy link
Owner

xabikos commented Apr 16, 2018

@eddjoke thanks for reporting this one and I am sorry for the late reply. There is an error indeed because of a forgotten duplicate key in snippets declaration. (More details)
Obviously this was not a problem for previous versions of VS Code but now it is. I have fixed this one. But I am going to wait for a few days to also merge #44 and then publish a new version, if you don't mind.

@edvinasjurele
Copy link
Author

@xabikos thanks for letting me know. To clarify, which key is a duplicate?

rpt is actually a unique prefix in the snippets.json, but I am wondering if it might clash with something else. That's why I cannot come up with the fix.

@xabikos
Copy link
Owner

xabikos commented Apr 17, 2018

@eddjoke rpt is indeed unique as prefix. The problem is that in the current version propTypes is declared two times. So it's

"propTypes": {
    "prefix": "rpt",
  },
  "propTypes": {
    "prefix": "rdp",
  },

This apparently was fine in older versions of VS code but not any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants