feat(typescript): make typescript a peer dependency #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why 3.6 instead of |
ZauberNerd
reviewed
Sep 10, 2019
jhiode
force-pushed
the
typescript-peerdep
branch
2 times, most recently
from
4255432
to
f9c1561
Compare
|
We use 3.2 now because that allows to use a package name in the |
ZauberNerd
reviewed
Sep 10, 2019
In order to improve flexibility we decided to let you chose the version of TypeScript you want to use. Please add the `typescript` package to your project. BREAKING CHANGE: TypeScript is now a peer dependency.
jhiode
force-pushed
the
typescript-peerdep
branch
from
f9c1561
to
680e5ae
Compare
ZauberNerd
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
In order to improve flexibility we changed TypeScript to be a peer dependency now.
Please install at least v3.6.0 of the
typescriptpackage.