Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xkb_keysym_to_utf8() requires output buffer size to be at least 7, but it should be 5 #418

Closed
LocalSpook opened this issue Dec 10, 2023 · 2 comments · Fixed by #489
Closed
Labels
enhancement Indicates new feature requests keysyms

Comments

@LocalSpook
Copy link

As I understand it, a size of 7 was needed when UTF-8 sequences could be up to 6 bytes long. Now that they're limited to 4, xkb_keysym_to_utf8()'s requirement should be reduced accordingly.

@wismill
Copy link
Member

wismill commented Dec 10, 2023

I agree. We just need max 4 bytes for the character plus 1 for the null character. I added a test for this in #414.

@wismill wismill added enhancement Indicates new feature requests keysyms labels Dec 10, 2023
@wismill
Copy link
Member

wismill commented Jul 12, 2024

A bit of history:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests keysyms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants