Possibly incorrect registry variant parsing

[mahkoh]

While implementing registry parsing in my implementation, I saw this sus code:

libxkbcommon/src/registry.c

Line 899 in d706e64

if (streq(v->name, config.name) && streq(v->name, l->name)) {

Comparing v->name and config->name looks incorrect given that

libxkbcommon/src/registry.c

Line 910 in d706e64

v->variant = steal(&config.name);

[wismill]

It’s not the same v, see:

libxkbcommon/src/registry.c

Line 906 in d706e64

v = rxkb_layout_create(&ctx->base);

.

[mahkoh]

But surely in the if, the v is the same both left and right of the &&.

[wismill]

Shouldn’t we have:

- if (streq(v->name, config.name) && streq(v->name, l->name)) {
+ if (streq(v->variant, config.name) && streq(v->name, l->name)) {

?

[mahkoh]

That is my thinking as well except that v->variant might be null iirc.