Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate and refactor key infrastructure #121

Closed
Tracked by #289 ...
johnabass opened this issue Mar 3, 2022 · 1 comment
Closed
Tracked by #289 ...

Separate and refactor key infrastructure #121

johnabass opened this issue Mar 3, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request jwk migration

Comments

@johnabass
Copy link
Contributor

The keys package is really showing its age. Not only does it only support PEM-encoded keys, but it also has significant semantic differences from the way JWK keys work:

  • Only RSA keys are supported
  • The key's purpose is expected to be configured rather than obtained from the key itself
  • The refresh mechanism is primitive and lacks support for HTTP caching headers and expiry set in the keys themselves

I think we should create a new repo that brings this functionality up-to-date. In addition to supporting JWKs and the semantics of using JWKs, it also needs better refresh features like backoffs and retries.

Most of the functionality we need is in https://pkg.go.dev/github.com/lestrrat-go/jwx/jwk, which makes a good starting point.

This work would be part of #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jwk migration
Projects
None yet
Development

No branches or pull requests

5 participants