Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Enable Bi-directional STREAM payments #50

Open
sappenin opened this issue Mar 19, 2020 · 1 comment
Open

Enable Bi-directional STREAM payments #50

sappenin opened this issue Mar 19, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@sappenin
Copy link
Contributor

sappenin commented Mar 19, 2020

Currently in SendMoneyService, the "sender address" is computed to be a somewhat invalid value because Hermes doesn't have sufficient SPSP receiver details to compute this value using the shared-secret in the STREAM.

We should either add this functionality into Hermes, or defer this on grounds that Hermes functionality should be in the Connector, which will have the SPSP server information in the runtime.

For now, this is not an issue because Hermes isn't facilitating bidirectional streams ATM.

@sappenin sappenin added the bug Something isn't working label Mar 19, 2020
@sappenin
Copy link
Contributor Author

Hermes doesn't currently have the ability to compute a return address because it doesn't have the shared-secret that an SPSP server would use to compute a valid ILP address.

Rather than adding this functionality to Hermes, instead we simply stop hermes from sending the SourceAddressFrame (enabled via the PR that fixes hyperledger-archives/quilt#445 in Quilt).

In the Connector, when we build DurableStreamSender, we can add this functionality because that Connector will have an SPSP server secret and will be able to construct ILP return addresses properly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant