Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible race in DomRenderer: Cannot read properties of undefined (reading 'replaceChildren') #4556

Closed
connor4312 opened this issue Jun 12, 2023 · 1 comment · Fixed by #4605
Assignees
Labels
area/renderer-dom type/bug Something is misbehaving
Milestone

Comments

@connor4312
Copy link

  1. In VS Code OSS, check out 59d8f2bd9c6
  2. Run a couple of unit tests, with the selfhost test provider for example, and open the TestResults view
  3. Click on the two top-level test result nodes to switch terminals.
  4. Notice you'll eventually get an error in the console. Her
    e's the debug state, it looks like there might be an off-by-one error where y references a row element that does not yet exist

image

@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2023

We fixed a similar problem recently, we probably need to clamp start/end to ensure they're valid.

@Tyriar Tyriar added type/bug Something is misbehaving area/renderer-dom labels Jun 12, 2023
@jerch jerch mentioned this issue Jul 31, 2023
21 tasks
@Tyriar Tyriar added this to the 5.3.0 milestone Aug 1, 2023
@Tyriar Tyriar self-assigned this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/renderer-dom type/bug Something is misbehaving
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants