Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RN0.59 #51

Open
ivan-kolesov opened this issue May 12, 2019 · 3 comments
Open

Support RN0.59 #51

ivan-kolesov opened this issue May 12, 2019 · 3 comments

Comments

@ivan-kolesov
Copy link

Please add support react native 0.59, changing build.gradle like https://github.com/ramsundark5/react-native-yz-vlcplayer/blob/master/android/build.gradle

@sessions-matthew
Copy link

From 011f08983f11b12993e4892acfb7366395b1d448 Mon Sep 17 00:00:00 2001
From: Gitea <[email protected]>
Date: Tue, 18 Jun 2019 09:09:56 -0700
Subject: [PATCH] update build.gradle

---
 android/build.gradle | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/android/build.gradle b/android/build.gradle
index e436539..7a4d10f 100644
--- a/android/build.gradle
+++ b/android/build.gradle
@@ -4,10 +4,11 @@ apply plugin: 'com.android.library'
 def _ext = rootProject.ext;
 
 def _reactNativeVersion = _ext.has('reactNative') ? _ext.reactNative : '+';
-def _compileSdkVersion = _ext.has('compileSdkVersion') ? _ext.compileSdkVersion : 26;
-def _buildToolsVersion = _ext.has('buildToolsVersion') ? _ext.buildToolsVersion : '26.0.3';
+def _compileSdkVersion = _ext.has('compileSdkVersion') ? _ext.compileSdkVersion : 28;
+def _buildToolsVersion = _ext.has('buildToolsVersion') ? _ext.buildToolsVersion : '28.0.3';
 def _minSdkVersion = _ext.has('minSdkVersion') ? _ext.minSdkVersion : 16;
-def _targetSdkVersion = _ext.has('targetSdkVersion') ? _ext.targetSdkVersion : 26;
+def _targetSdkVersion = _ext.has('targetSdkVersion') ? _ext.targetSdkVersion : 28;
+def _supportLibVersion = _ext.has('supportLibVersion') ? _ext.supportLibVersion: '28.0.0'
 
 android {
     compileSdkVersion _compileSdkVersion
@@ -36,4 +37,9 @@ dependencies {
     provided "com.facebook.react:react-native:${_reactNativeVersion}"
     compile 'com.yyl.vlc:vlc-android-sdk:3.0.13'
     //compile 'de.mrmaffen:vlc-android-sdk:2.0.6'
+    implementation "com.android.support:support-annotations:${_supportLibVersion}"
+    implementation "com.android.support:support-compat:${_supportLibVersion}"
+    implementation "com.android.support:support-core-utils:${_supportLibVersion}"
+    implementation "com.android.support:support-core-ui:${_supportLibVersion}"
+    implementation "com.android.support:support-fragment:${_supportLibVersion}"
 }
-- 
2.22.0


@nachumFreedman
Copy link

did this work?

@ivan-kolesov
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants