Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream shouldn't apologise when there are no records #1178

Closed
johnbillion opened this issue Sep 25, 2020 · 0 comments · Fixed by #1182
Closed

Stream shouldn't apologise when there are no records #1178

johnbillion opened this issue Sep 25, 2020 · 0 comments · Fixed by #1182

Comments

@johnbillion
Copy link
Contributor

Bug Report

Expected Behavior

When there are no records to show, the messaging to the user should be clear.

Actual Behavior

Stream apologises to the user: Sorry, no activity records were found. It's a small issue but there is no reason for Stream to apologise here, and for a non-native English speaker this message may not be clear and may suggest there was a problem fetching the records, when in fact everything is working as expected.

I recommend that the Sorry prefix is removed from this phrase to enhance the clarity.

Steps to Reproduce the Problem

  1. Clear your Stream database from the Stream -> Settings -> Advanced menu
  2. View the activity log
  3. See an apology
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants